From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC261EA76 for ; Tue, 30 May 2023 18:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=24Ry0beQgWrLSFF8krNBwN4KJRINBEkewKnwBgtX8s0=; b=IXdLdyGG3/j+MW0vZgOMVsZew4 EQGHw0rZ/Qs/tVekOd/EA0IXxQUyJ4eUybgB6Zqzh80ikhKQd9h6gxjv7NX53TEOoYyG/LhjowQmn TG/u7iYYPAwDYfVtPtfHtbBXcQTKfgck38ghgHXddVNwdaybMLMEz9YSjFNcA6owTljt2GczGBWvC N5a/P+mDnHmGlQ8AxESLLF8Y+W2+Y3j14xHBInQkanZR0k5I7MBvp3+AxjZBa/GsgbdYgWKuSlpCj Yndybi5XQK5GV2xuzH1nFjq/yf3FQ8auqtcDKz4CxK6GYh2GI23rhZvuGflKVMvvDjwIld9cJVWjA 65a9QJUw==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q433y-00DzWB-3A; Tue, 30 May 2023 11:23:14 -0600 Message-ID: <8a411404-a2fc-694c-c41e-5d7efba38472@deltatee.com> Date: Tue, 30 May 2023 11:23:12 -0600 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-CA To: Robin Murphy , hch@infradead.org Cc: m.szyprowski@samsung.com, iommu@lists.linux.dev, catalin.marinas@arm.com, linux-kernel@vger.kernel.org References: From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: robin.murphy@arm.com, hch@infradead.org, m.szyprowski@samsung.com, iommu@lists.linux.dev, catalin.marinas@arm.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) On 2023-05-25 11:46, Robin Murphy wrote: > sg_is_dma_bus_address() is inconsistent with the naming pattern of its > corresponding setters and its own kerneldoc, so take the majority vote > and rename it sg_dma_is_bus_address() (and fix up the missing > underscores in the kerneldoc too). This gives us a nice clear pattern > where SG DMA flags are SG_DMA_, and the helpers for acting on them > are sg_dma__(). > > Signed-off-by: Robin Murphy Looks good to me. Thanks. Reviewed-by: Logan Gunthorpe