From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B8FC433DB for ; Wed, 6 Jan 2021 01:14:31 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C3C222D01 for ; Wed, 6 Jan 2021 01:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C3C222D01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 67D082045D; Wed, 6 Jan 2021 01:14:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x+qNGl9XcXlJ; Wed, 6 Jan 2021 01:14:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 0F678203C9; Wed, 6 Jan 2021 01:14:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F35DFC0891; Wed, 6 Jan 2021 01:14:28 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C0DE3C013A for ; Wed, 6 Jan 2021 01:14:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BCEDA84ECD for ; Wed, 6 Jan 2021 01:14:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UloCzSrg-TlV for ; Wed, 6 Jan 2021 01:14:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 776D684EA3 for ; Wed, 6 Jan 2021 01:14:26 +0000 (UTC) IronPort-SDR: uCQQrhjfP+WjFRy0pbt50fBilmlOIjIgF/FoLjc0fjgIvxc2dAco3cMJP+0MCc5H9OHd1izyYN mn8LD2t4TZEA== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="156399440" X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="156399440" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 17:14:26 -0800 IronPort-SDR: Uc7toaoXygV4ij3rNtEGMj56KxFlvoN5+ltEWxTtgOBsH+UAbO8oS2jZpkufOe3pwrHjLOjtiy I8HD2A7cRDQA== X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="379090776" Received: from jan-mobl.ccr.corp.intel.com (HELO [10.255.29.66]) ([10.255.29.66]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 17:14:23 -0800 Subject: Re: [PATCH 3/5] iommu/vt-d: Remove unused dma map/unmap trace events To: Will Deacon References: <20201231005323.2178523-1-baolu.lu@linux.intel.com> <20201231005323.2178523-3-baolu.lu@linux.intel.com> <20210105190443.GB12182@willie-the-truck> From: Lu Baolu Message-ID: <8bf33c93-3154-e832-1197-891c684d6ded@linux.intel.com> Date: Wed, 6 Jan 2021 09:14:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210105190443.GB12182@willie-the-truck> Content-Language: en-US Cc: Ashok Raj , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Guo Kaijie X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Will, On 2021/1/6 3:04, Will Deacon wrote: > On Thu, Dec 31, 2020 at 08:53:21AM +0800, Lu Baolu wrote: >> With commit c588072bba6b5 ("iommu/vt-d: Convert intel iommu driver to >> the iommu ops"), the trace events for dma map/unmap have no users any >> more. Remove them so that they don't show up under >> /sys/kernel/debug/tracing/events/intel_iommu. The users should use the >> map/unmap traces defined in the iommu core from now on. >> >> Fixes: c588072bba6b5 ("iommu/vt-d: Convert intel iommu driver to the iommu ops") >> Signed-off-by: Lu Baolu >> --- >> include/trace/events/intel_iommu.h | 119 ----------------------------- >> 1 file changed, 119 deletions(-) > > Is this needed in 5.11, or can it wait until 5.12? It's necessary for 5.11 as far as I can see. Without this, users still see the events under /sys/kernel/debug/tracing/events/intel_iommu, but they will get nothing traced even they enable the events. > > Will > Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu