From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] iommu/vt-d: Fix possible recursive locking in intel_iommu_init()
Date: Sun, 24 Jul 2022 10:59:34 +0800 [thread overview]
Message-ID: <8e970367-746e-0e74-ba39-e941fdbfdab7@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB5276287E75395A59865812978C919@BN9PR11MB5276.namprd11.prod.outlook.com>
Hi Kevin,
On 2022/7/21 15:39, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Tuesday, July 19, 2022 7:53 AM
>>
>> @@ -88,7 +89,8 @@ extern struct list_head dmar_drhd_units;
>> static inline bool dmar_rcu_check(void)
>> {
>> return rwsem_is_locked(&dmar_global_lock) ||
>> - system_state == SYSTEM_BOOTING;
>> + system_state == SYSTEM_BOOTING ||
>> + (IS_ENABLED(CONFIG_INTEL_IOMMU)
>> && !intel_iommu_enabled);
>> }
>
> intel_iommu_enabled is 0 if CONFIG_INTEL_IOMMU is not set.
>
> same for other similar checks.
Sorry that I didn't get your point. If CONFIG_INTEL_IOMMU is not set,
IS_ENABLED(CONFIG_INTEL_IOMMU) is 0. The adding check has no effect. Did
I miss anything?
Best regards,
baolu
next prev parent reply other threads:[~2022-07-24 2:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 23:53 [PATCH 1/1] iommu/vt-d: Fix possible recursive locking in intel_iommu_init() Lu Baolu
2022-07-21 7:39 ` Tian, Kevin
2022-07-24 2:59 ` Baolu Lu [this message]
2022-07-25 7:40 ` Tian, Kevin
2022-07-25 9:39 ` Baolu Lu
2022-09-08 6:13 ` Baolu Lu
2022-09-08 6:31 ` Tian, Kevin
-- strict thread matches above, loose matches on Subject: below --
2022-09-11 3:18 [PATCH 0/1] iommu/vt-d: Fixes for v6.0-rc5 Lu Baolu
2022-09-11 3:18 ` [PATCH 1/1] iommu/vt-d: Fix possible recursive locking in intel_iommu_init() Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e970367-746e-0e74-ba39-e941fdbfdab7@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox