From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
To: Zhen Ni <zhen.ni@easystack.cn>,
joro@8bytes.org, will@kernel.org, robin.murphy@arm.com
Cc: iommu@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Fix ivrs_base memleak in early_amd_iommu_init()
Date: Fri, 22 Aug 2025 15:59:20 -0500 [thread overview]
Message-ID: <8f6cb260-d378-401a-ab65-8542307d08bc@amd.com> (raw)
In-Reply-To: <20250822024915.673427-1-zhen.ni@easystack.cn>
On 8/21/2025 9:49 PM, Zhen Ni wrote:
> Fix a permanent ACPI table memory leak in early_amd_iommu_init() when
> CMPXCHG16B feature is not supported
>
> Fixes: 82582f85ed22 ("iommu/amd: Disable AMD IOMMU if CMPXCHG16B feature is not supported")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
> ---
> drivers/iommu/amd/init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 7b5af6176de9..dddc432de7b0 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -3067,7 +3067,8 @@ static int __init early_amd_iommu_init(void)
>
> if (!boot_cpu_has(X86_FEATURE_CX16)) {
> pr_err("Failed to initialize. The CMPXCHG16B feature is required.\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out;
> }
>
> /*
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Thanks,
Suravee
next prev parent reply other threads:[~2025-08-22 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 2:49 [PATCH] iommu/amd: Fix ivrs_base memleak in early_amd_iommu_init() Zhen Ni
2025-08-22 20:59 ` Suthikulpanit, Suravee [this message]
2025-09-05 12:42 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f6cb260-d378-401a-ab65-8542307d08bc@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox