Linux IOMMU Development
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Nadav Amit <nadav.amit@gmail.com>, Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Nadav Amit <namit@vmware.com>, Jiajun Cao <caojiajun@vmware.com>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is on
Date: Mon, 21 Jun 2021 13:37:29 +0100	[thread overview]
Message-ID: <91ea2a97-2db6-3e10-9c2e-80f6a4e0f733@huawei.com> (raw)
In-Reply-To: <20210616100500.174507-3-namit@vmware.com>

On 16/06/2021 11:04, Nadav Amit wrote:
> -	if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE))
> +	if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) {
> +		if (!amd_iommu_unmap_flush)
> +			pr_warn("IOMMU batching is disabled due to virtualization");

This is missing the '\n', like the Intel driver.

And, JFYI, we are also downgrading that same print to info level (in the 
Intel driver).

Thanks,
John

> +
>   		amd_iommu_np_cache = true;
> +		amd_iommu_unmap_flush = true;

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-06-21 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 10:04 [PATCH v4 0/7] iommu/amd: Enable page-selective flushes Nadav Amit
2021-06-16 10:04 ` [PATCH v4 1/7] iommu/amd: Selective flush on unmap Nadav Amit
2021-06-16 10:04 ` [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is on Nadav Amit
2021-06-21 12:37   ` John Garry [this message]
2021-06-16 10:04 ` [PATCH v4 3/7] iommu: Improve iommu_iotlb_gather helpers Nadav Amit
2021-06-16 10:04 ` [PATCH v4 4/7] iommu: Factor iommu_iotlb_gather_is_disjoint() out Nadav Amit
2021-06-16 10:04 ` [PATCH v4 5/7] iommu/amd: Tailored gather logic for AMD Nadav Amit
2021-06-16 10:04 ` [PATCH v4 6/7] iommu/amd: Sync once for scatter-gather operations Nadav Amit
2021-06-16 10:05 ` [PATCH v4 7/7] iommu/amd: Use only natural aligned flushes in a VM Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ea2a97-2db6-3e10-9c2e-80f6a4e0f733@huawei.com \
    --to=john.garry@huawei.com \
    --cc=caojiajun@vmware.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadav.amit@gmail.com \
    --cc=namit@vmware.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox