From: Lu Baolu <baolu.lu@linux.intel.com>
To: Huang Adrian <adrianhuang0701@gmail.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Nirmal Patel <nirmal.patel@linux.intel.com>,
iommu@lists.linux-foundation.org,
Adrian Huang <ahuang12@lenovo.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] iommu/vt-d: Fix list_add double add when enabling VMD and scalable mode
Date: Tue, 15 Feb 2022 13:36:40 +0800 [thread overview]
Message-ID: <9272df91-0406-63a6-47d3-a8ae16875fdb@linux.intel.com> (raw)
In-Reply-To: <CAHKZfL2xEybeVu=DWqX6okJd32hU3k4-sauRVA8v-JTedBPwnQ@mail.gmail.com>
On 2/15/22 12:28 PM, Huang Adrian wrote:
> On Tue, Feb 15, 2022 at 9:26 AM Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>
>> On 2/14/22 5:32 PM, Huang Adrian wrote:
>>> Hi Baolu,
>>>
>>> On Mon, Feb 14, 2022 at 8:35 AM Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>>>
>>>> Hi Adrian,
>>>>
>>>>> The solution is to prevent from allocating pasid table if those
>>>>> devices are subdevices of the VMD device.
>>>>
>>>> Thanks for your patch!
>>>>
>>>> Is this the only patch that is needed to make VMD devices work in VT-d
>>>> scalable mode?
>>>
>>> Yes, it is. With this patch, the system can boot successfully and the
>>> RAID device connected to the VMD device can be recognized by the host
>>> OS. I also ran a simple IO stress on the RAID device by compiling
>>> kernel `$ make -j $(nproc)`. Everything looks good.
>>
>> Thank you! So how far should this patch be back ported?
>
> Thanks for the feedback.
>
> Do you mean the CC stable kernel tag? Something like: "Cc:
> stable@vger.kernel.org # v5.8+"?
>
>> Can you please add a Fixes tag?
>
> Fixes: 0bbeb01a4faf ("iommu/vt-d: Manage scalalble mode PASID tables")
>
> Do you want me to send a v2 with the CC stable kernel tag and Fixes
> tag? Or, do you just need to take the Fixes tag directly without
> sending a v2?
I don't think we can back port it as far as that. Probably,
Fixes: 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping")
Cc: stable@vger.kernel.org # v5.6+
Please verify whether v5.6 works with your patch back ported. If it
works, please send a v2 with above tags appended.
> -- Adrian
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-02-15 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 2:45 [PATCH] iommu/vt-d: Fix list_add double add when enabling VMD and scalable mode Adrian Huang
2022-02-14 0:34 ` Lu Baolu
2022-02-14 9:32 ` Huang Adrian
2022-02-15 1:24 ` Lu Baolu
2022-02-15 4:28 ` Huang Adrian
2022-02-15 5:36 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9272df91-0406-63a6-47d3-a8ae16875fdb@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=adrianhuang0701@gmail.com \
--cc=ahuang12@lenovo.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.derrick@linux.dev \
--cc=kevin.tian@intel.com \
--cc=nirmal.patel@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox