From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auger Eric Subject: Re: [RFC v3 17/21] iommu/smmuv3: Report non recoverable faults Date: Wed, 16 Jan 2019 13:49:48 +0100 Message-ID: <93599256-947f-d267-6b72-0759e17b4df1@redhat.com> References: <20190108102633.17482-1-eric.auger@redhat.com> <20190108102633.17482-18-eric.auger@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Jean-Philippe Brucker , "eric.auger.pro@gmail.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "kvmarm@lists.cs.columbia.edu" , "joro@8bytes.org" , "alex.williamson@redhat.com" , "jacob.jun.pan@linux.intel.com" , "yi.l.liu@linux.intel.com" , Will Deacon , Robin Murphy Cc: Marc Zyngier , "kevin.tian@intel.com" , "ashok.raj@intel.com" List-Id: iommu@lists.linux-foundation.org Hi Jean, On 1/16/19 1:25 PM, Jean-Philippe Brucker wrote: > On 15/01/2019 21:06, Auger Eric wrote: >>>> + iommu_report_device_fault(master->dev, &event); >>> >>> We should return here if the fault is successfully injected >> >> Even if the fault gets injected in the guest can't it be still useful to >> get the message below on host side? > > I don't think we should let the guest flood the host log by issuing > invalid DMA (or are there other cases where the guest can freely print > stuff in the host?) We do print all errors at the moment, but we should > tighten this once there is an upstream solution to let the guest control > DMA mappings. OK thank you for the clarification. Yes it makes sense to skip those traces then. Thanks Eric > > Thanks, > Jean >