Linux IOMMU Development
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: fix DMA ops layering violations in vmwgfx
Date: Tue, 8 Jan 2019 09:51:45 +0000	[thread overview]
Message-ID: <99091bb861e21d5bb4182f08dedbc494c637cc0f.camel@vmware.com> (raw)
In-Reply-To: <20190105080108.14837-1-hch@lst.de>

Hi, Christoph,

On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote:
> Hi Thomas,
> 
> vmwgfx has been doing some odd checks based on DMA ops which rely
> on deep DMA mapping layer internals, and I think the changes in
> Linux 4.21 finally broke most of these implicit assumptions.

Thanks. 
What we're really trying to do here is to try to detect the situation
where DMA remapping using hardware IOMMUs is going on but memory is
still coherent, since the driver can currently only work with coherent
memory[1]. Currently we use intel_iommu_enabled to detect this
situation, but it would be really helpful if there were a generic bool
that advertizes this situation since we need to deal with other IOMMUs
as well going forward. Any suggestion?

Comments on the patches separately.

Thanks,
Thomas




> 
> The real fix is in patch 3, but I think the others are important
> to make it clear what is actually going on.

  parent reply	other threads:[~2019-01-08  9:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  8:01 fix DMA ops layering violations in vmwgfx Christoph Hellwig
2019-01-05  8:01 ` [PATCH 1/4] drm/vmwgfx: remove CONFIG_X86 ifdefs Christoph Hellwig
2019-01-05  8:01 ` [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs Christoph Hellwig
2019-01-08 10:03   ` Thomas Hellstrom
     [not found]   ` <20190105080108.14837-3-hch-jcswGhMUV9g@public.gmane.org>
2019-01-08 10:55     ` Thomas Hellstrom
2019-01-05  8:01 ` [PATCH 3/4] drm/vmwgfx: fix the check when to use dma_alloc_coherent Christoph Hellwig
2019-01-05  8:01 ` [PATCH 4/4] drm/vmwgfx: unwind spaghetti code in vmw_dma_select_mode Christoph Hellwig
     [not found]   ` <20190105080108.14837-5-hch-jcswGhMUV9g@public.gmane.org>
2019-01-08 10:56     ` Thomas Hellstrom
2019-01-08  9:51 ` Thomas Hellstrom [this message]
     [not found]   ` <99091bb861e21d5bb4182f08dedbc494c637cc0f.camel-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2019-01-08 13:12     ` fix DMA ops layering violations in vmwgfx hch-jcswGhMUV9g
     [not found]       ` <20190108131227.GB6003-jcswGhMUV9g@public.gmane.org>
2019-01-08 18:25         ` Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99091bb861e21d5bb4182f08dedbc494c637cc0f.camel@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=Linux-graphics-maintainer@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox