From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Joe Perches <joe@perches.com>,
hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com
Cc: iommu@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: Use 'bitmap_zalloc()' when applicable
Date: Sun, 24 Oct 2021 20:18:53 +0200 [thread overview]
Message-ID: <994b268f-ea33-bf82-96ab-c20057ba4930@wanadoo.fr> (raw)
In-Reply-To: <c8cd95bc81173fdbdff4f2b504db3ce89119fa0d.camel@perches.com>
Le 24/10/2021 à 19:54, Joe Perches a écrit :
> On Sun, 2021-10-24 at 19:40 +0200, Christophe JAILLET wrote:
>> 'dma_mem->bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify code,
>> improve the semantic and avoid some open-coded arithmetic in allocator
>> arguments.
>
> There is a cocci script for some of these.
>
> https://lore.kernel.org/all/08b89608cfb1280624d1a89ead6547069f9a4c31.camel@perches.com/
>
Hi Joe,
yes I know.
As it is public, I guess that new comers may have seen it and want to
propose patches based on your cocci script.
So, for now, I'm more focused on things that are not spotted by your
script. I look for places where the size computation is not done within
the kmalloc() or eq. function.
CJ
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-10-24 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 17:40 [PATCH] dma-mapping: Use 'bitmap_zalloc()' when applicable Christophe JAILLET
2021-10-24 17:54 ` Joe Perches
2021-10-24 18:18 ` Christophe JAILLET [this message]
2021-10-27 6:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994b268f-ea33-bf82-96ab-c20057ba4930@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox