From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: implement generic dma_map_ops for IOMMUs v3 Date: Mon, 29 Apr 2019 16:03:29 +0100 Message-ID: <9ae8ce99-65a8-711d-b17d-165df7e280d4@arm.com> References: <20190422175942.18788-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190422175942.18788-1-hch@lst.de> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , Catalin Marinas , Will Deacon Cc: Joerg Roedel , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On 22/04/2019 18:59, Christoph Hellwig wrote: > Hi Robin, > > please take a look at this series, which implements a completely generic > set of dma_map_ops for IOMMU drivers. This is done by taking the > existing arm64 code, moving it to drivers/iommu and then massaging it > so that it can also work for architectures with DMA remapping. This > should help future ports to support IOMMUs more easily, and also allow > to remove various custom IOMMU dma_map_ops implementations, like Tom > was planning to for the AMD one. Modulo a few nits, I think this looks pretty much good to go, and it would certainly be good to get as much as reasonable queued soon for the sake of progress elsewhere. Catalin, Will, I think the arm64 parts are all OK but please take a look to confirm. Thanks, Robin. > > A git tree is also available at: > > git://git.infradead.org/users/hch/misc.git dma-iommu-ops.3 > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops.3 > > Changes since v2: > - address various review comments and include patches from Robin > > Changes since v1: > - only include other headers in dma-iommu.h if CONFIG_DMA_IOMMU is enabled > - keep using a scatterlist in iommu_dma_alloc > - split out mmap/sgtable fixes and move them early in the series > - updated a few commit logs > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD47EC43219 for ; Mon, 29 Apr 2019 15:06:21 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A905E20651 for ; Mon, 29 Apr 2019 15:06:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A905E20651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7C2992204; Mon, 29 Apr 2019 15:06:21 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 231A321EF for ; Mon, 29 Apr 2019 15:03:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 26C5B711 for ; Mon, 29 Apr 2019 15:03:32 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0FAF80D; Mon, 29 Apr 2019 08:03:32 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 689D63F5C1; Mon, 29 Apr 2019 08:03:31 -0700 (PDT) Subject: Re: implement generic dma_map_ops for IOMMUs v3 To: Christoph Hellwig , Catalin Marinas , Will Deacon References: <20190422175942.18788-1-hch@lst.de> From: Robin Murphy Message-ID: <9ae8ce99-65a8-711d-b17d-165df7e280d4@arm.com> Date: Mon, 29 Apr 2019 16:03:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190422175942.18788-1-hch@lst.de> Content-Language: en-GB Cc: Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="UTF-8"; format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190429150329.8Cz5kPYeFkAwSAWSTyTTFZx1AWlJO7xslgfC8a3vTOo@z> On 22/04/2019 18:59, Christoph Hellwig wrote: > Hi Robin, > > please take a look at this series, which implements a completely generic > set of dma_map_ops for IOMMU drivers. This is done by taking the > existing arm64 code, moving it to drivers/iommu and then massaging it > so that it can also work for architectures with DMA remapping. This > should help future ports to support IOMMUs more easily, and also allow > to remove various custom IOMMU dma_map_ops implementations, like Tom > was planning to for the AMD one. Modulo a few nits, I think this looks pretty much good to go, and it would certainly be good to get as much as reasonable queued soon for the sake of progress elsewhere. Catalin, Will, I think the arm64 parts are all OK but please take a look to confirm. Thanks, Robin. > > A git tree is also available at: > > git://git.infradead.org/users/hch/misc.git dma-iommu-ops.3 > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops.3 > > Changes since v2: > - address various review comments and include patches from Robin > > Changes since v1: > - only include other headers in dma-iommu.h if CONFIG_DMA_IOMMU is enabled > - keep using a scatterlist in iommu_dma_alloc > - split out mmap/sgtable fixes and move them early in the series > - updated a few commit logs > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu