From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC52C4BA12 for ; Wed, 26 Feb 2020 13:55:30 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2292C24680 for ; Wed, 26 Feb 2020 13:55:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2292C24680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EAF2287987; Wed, 26 Feb 2020 13:55:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gtCDf+GCHiCS; Wed, 26 Feb 2020 13:55:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id A1BF08796D; Wed, 26 Feb 2020 13:55:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B401C08A0; Wed, 26 Feb 2020 13:55:25 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0704FC0177 for ; Wed, 26 Feb 2020 13:55:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E968F20130 for ; Wed, 26 Feb 2020 13:55:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3iYDvEjxvVpE for ; Wed, 26 Feb 2020 13:55:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by silver.osuosl.org (Postfix) with ESMTP id A70262011A for ; Wed, 26 Feb 2020 13:55:19 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A59B30E; Wed, 26 Feb 2020 05:55:19 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 969CC3F9E6; Wed, 26 Feb 2020 05:55:17 -0800 (PST) Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks To: Matthias Kaehlcke , Sharat Masetty References: <1582186342-3484-1-git-send-email-smasetty@codeaurora.org> <1582186342-3484-2-git-send-email-smasetty@codeaurora.org> <20200220210242.GC24720@google.com> From: Robin Murphy Message-ID: <9cb8551f-becd-d84e-e0ce-43f13b84ad89@arm.com> Date: Wed, 26 Feb 2020 13:55:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200220210242.GC24720@google.com> Content-Language: en-GB Cc: devicetree@vger.kernel.org, will@kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org, dri-devel@freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" [ /me fires off MAINTAINERS patch... ] On 20/02/2020 9:02 pm, Matthias Kaehlcke wrote: > On Thu, Feb 20, 2020 at 01:42:22PM +0530, Sharat Masetty wrote: >> This patch adds a clock definition needed for powering on the GPU TBUs >> and the GPU TCU. >> >> Signed-off-by: Sharat Masetty >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 6515dbe..235c0df 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -28,6 +28,7 @@ properties: >> - enum: >> - qcom,msm8996-smmu-v2 >> - qcom,msm8998-smmu-v2 >> + - qcom,sc7180-smmu-v2 > > The addition of the compatible string isn't (directly) related with $subject, > this should be done in a separate patch. ...or the patch should just be accurately described as "add support for new variant X, which requires an additional clock Y". And speaking of which, can anyone clarify how "TCU and TBU core clock" manages to abbreviate to "mem_iface_clk"? I would have naively assumed something like "core" would be most logical. Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu