From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D5D2C433F5 for ; Mon, 6 Dec 2021 08:28:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 060174016B; Mon, 6 Dec 2021 08:28:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wH5oziMbACjA; Mon, 6 Dec 2021 08:28:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8930A400F4; Mon, 6 Dec 2021 08:28:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3865CC001E; Mon, 6 Dec 2021 08:28:21 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94DB6C0012 for ; Mon, 6 Dec 2021 08:28:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 809E4400A4 for ; Mon, 6 Dec 2021 08:28:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mediatek.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k3Nr-bW8jtju for ; Mon, 6 Dec 2021 08:28:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by smtp2.osuosl.org (Postfix) with ESMTPS id 046E540018 for ; Mon, 6 Dec 2021 08:28:09 +0000 (UTC) X-UUID: 5af0a9b0f4b242b691cda3217dc8d290-20211206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=x6YtsVKT5SbA+fAmPG41G/VMiY4QVQjlGJqlNFJ+A68=; b=GNUUDpkb4nqaw/D5eLC44xtXblzMMrj+glo2DaXZ6Z3JnNut3AKqnZA3VwvxuKsa/UsGvp5Fbrs00PXQB7UPFpP7Di7ZcddIe1JcRvKLW/W9Jv3FzvVGmY/WbsYO/4NhRwn2rW7wO9hHVjWQSs24JSvpNTVWveso0ioyjagJrKo=; X-UUID: 5af0a9b0f4b242b691cda3217dc8d290-20211206 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 79413400; Mon, 06 Dec 2021 16:28:05 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 6 Dec 2021 16:28:03 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 6 Dec 2021 16:28:01 +0800 Message-ID: <9fd624a9f0752b92f309c0bb8524547f250830cb.camel@mediatek.com> Subject: Re: [PATCH v3 12/33] iommu/mediatek: Always tlb_flush_all when each PM resume From: Yong Wu To: Dafna Hirschfeld Date: Mon, 6 Dec 2021 16:28:00 +0800 In-Reply-To: <58b13d3a-e89b-d2e3-278d-af8859d901b9@collabora.com> References: <20210923115840.17813-1-yong.wu@mediatek.com> <20210923115840.17813-13-yong.wu@mediatek.com> <5c4dd67ae7c81721d8cfd2c3b23b7c6df493cb5a.camel@mediatek.com> <4dd4cf8d-0f52-afae-f7d9-8e3cfdf3b729@collabora.com> <128eb1874127b2b9b42a7419e26090d1d192666f.camel@mediatek.com> <58b13d3a-e89b-d2e3-278d-af8859d901b9@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, srv_heupstream@mediatek.com, Krzysztof Kozlowski , Robin Murphy , sebastian.reichel@collabora.com, yen-chang.chen@mediatek.com, Fabien Parent , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, yf.wang@mediatek.com, Hsin-Yi Wang , Matthias Brugger , Collabora Kernel ML , Will Deacon , mingyuan.ma@mediatek.com, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, 2021-11-30 at 13:33 +0200, Dafna Hirschfeld wrote: > > On 30.11.21 09:39, Yong Wu wrote: > > On Sat, 2021-11-27 at 12:11 +0200, Dafna Hirschfeld wrote: > > > > > > On 10.11.21 09:50, Yong Wu wrote: > > > > On Wed, 2021-11-10 at 07:29 +0200, Dafna Hirschfeld wrote: > > > > > > > > > > On 10.11.21 04:20, Yong Wu wrote: > > > > > > On Tue, 2021-11-09 at 14:21 +0200, Dafna Hirschfeld wrote: > > > > > > > Hi > > > > > > > This patch is needed in order to update the tlb when a > > > > > > > device > > > > > > > is > > > > > > > powered on. > > > > > > > Could you send this patch alone without the whole series > > > > > > > so > > > > > > > it > > > > > > > get > > > > > > > accepted easier? > > > > > > > > > > > > Which SoC are you testing on? In previous SoC, the IOMMU HW > > > > > > don't > > > > > > have > > > > > > power-domain, and we have a "has_pm"[1] in the tlb function > > > > > > for > > > > > > that > > > > > > case. The "has_pm" should be always 0 for the previous SoC > > > > > > like > > > > > > mt8173, > > > > > > it should always tlb synchronize. > > > > > > > > > > > > thus, Could you help share more about your issue? In which > > > > > > case > > > > > > it > > > > > > lack > > > > > > the necessary tlb operation. At least, We need confirm if > > > > > > it > > > > > > needs > > > > > > a > > > > > > "Fixes" tags if sending this patch alone. > > > > > > > > > > Hi, > > > > > I work with the mtk-vcodec driver on mt8173. As you wrote, > > > > > the > > > > > iommu > > > > > doesn't > > > > > have a power-domain and so when allocating buffers before the > > > > > device > > > > > is powered > > > > > on, there is the warning > > > > > "Partial TLB flush timed out, falling back to full flush" > > > > > flooding the log buf. > > > > > > > > oh. Thanks very much for your information. Get it now. > > > > > > > > This issue should be introduced by the: > > > > > > > > b34ea31fe013 ("iommu/mediatek: Always enable the clk on > > > > resume") > > > > > > Hi, reverting this commit didn't solve those warnings, > > > I think this is because in the function mtk_iommu_attach_device > > > the first call to pm_runtime_resume_and_get does not turn the > > > clks on > > > since m4u_dom is not yet initialize. And then > > > mtk_iommu_attach_device > > > calls pm_runtime_put right after mtk_iommu_hw_init is called > > > (where the clks are turned on) > > > > oh. Right. this is also related with the patch of "Add power-domain > > operation". > > > > The current problem is that there is a redundant log of "Partial > > TLB > > flush timed out" in mt8173. We need fix this issue firstly. Are you > > going to prepare the patches again? If not, I could help this. You > > could help confirm them if you are free. > > Hi, > I already sent a patch last week: > https://lore.kernel.org/linux-iommu/afb46ad6ca9477a2bf71233858406caa6ccb1588.camel@mediatek.com/T/ > could you please review it? I have replied them before you send this reply. Have you got them? https://lore.kernel.org/linux-iommu/afb46ad6ca9477a2bf71233858406caa6ccb1588.camel@mediatek.com/ https://lore.kernel.org/linux-iommu/6abef78f6447c626b737fd35688f421c29871f43.camel@mediatek.com/ Thanks. > > Thanks, > Dafna > > > > > > > Thanks. > > > > > > > > thanks, > > > Dafna > > > > > > > > > > > > > > tlb failed due to the bclk is not enabled. Could you help try > > > > that > > > > after reverting this? > > > > > > > > > > > > > > Sebastian Reichel suggested to remove the 'if(has_pm)' check > > > > > to > > > > > avoid > > > > > this warning, > > > > > and avoid flushing the tlb if the device is off: > > > > > > > > > > [1] http://ix.io/3Eyr > > > > > > > > > > This fixes the warning, but then the tlb is not flushed in > > > > > sync, > > > > > Therefore the tlb should be flushed when the device is > > > > > resumed. > > > > > > > > > > So the two patches (the one suggested in the link [1] and > > > > > this > > > > > patch) > > > > > should be sent together as a 2-patch series. > > > > > > > > then this is reasonable. You could help this into a new > > > > patchset if > > > > you > > > > are free(add Fixes tag). > > > > > > > > Thanks. > > > > > > > > > > > > > > Thanks, > > > > > Dafna > > > > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu