[PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[Niklas Söderlund]

The function dma_set_max_seg_size() can return either 0 on success or
-EIO on error. Change its return type from unsigned int to int to
capture this.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 include/linux/dma-mapping.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
 	return SZ_64K;
 }
 
-static inline unsigned int dma_set_max_seg_size(struct device *dev,
-						unsigned int size)
+static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
 {
 	if (dev->dma_parms) {
 		dev->dma_parms->max_segment_size = size;
-- 
2.18.0

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[Geert Uytterhoeven]

On Wed, Aug 29, 2018 at 11:30 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[Niklas Söderlund]

Hi,

A gentle ping on this patch.

On 2018-08-29 23:29:21 +0200, Niklas Söderlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
> ---
>  include/linux/dma-mapping.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
>  	return SZ_64K;
>  }
>  
> -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> -						unsigned int size)
> +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
>  {
>  	if (dev->dma_parms) {
>  		dev->dma_parms->max_segment_size = size;
> -- 
> 2.18.0
> 

-- 
Regards,
Niklas Söderlund

Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[Niklas Söderlund]

On 2018-11-02 11:22:54 +0100, Niklas Söderlund wrote:
> Hi,
> 
> A gentle ping on this patch.

A slightly harder ping :-)

> 
> On 2018-08-29 23:29:21 +0200, Niklas Söderlund wrote:
> > The function dma_set_max_seg_size() can return either 0 on success or
> > -EIO on error. Change its return type from unsigned int to int to
> > capture this.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> >  include/linux/dma-mapping.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> >  	return SZ_64K;
> >  }
> >  
> > -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> > -						unsigned int size)
> > +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> >  {
> >  	if (dev->dma_parms) {
> >  		dev->dma_parms->max_segment_size = size;
> > -- 
> > 2.18.0
> > 
> 
> -- 
> Regards,
> Niklas Söderlund

-- 
Regards,
Niklas Söderlund

Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

[Christoph Hellwig]

On Wed, Aug 29, 2018 at 11:29:21PM +0200, Niklas Söderlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>

Thanks, applied to the dma-mapping tree for 4.21.