From: "Danilo Krummrich" <dakr@kernel.org>
To: "Will Deacon" <will@kernel.org>
Cc: "Mark Brown" <broonie@kernel.org>,
"Wang Jiayue" <akaieurus@gmail.com>, <hanguidong02@gmail.com>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<Aishwarya.TCV@arm.com>, <chenqiuji666@gmail.com>,
<linux-kernel@vger.kernel.org>, <m.szyprowski@samsung.com>,
<robin.clark@oss.qualcomm.com>, <robin.murphy@arm.com>,
<joro@8bytes.org>, <iommu@lists.linux.dev>,
<quic_c_gdjako@quicinc.com>, <dmitry.baryshkov@linaro.org>,
<dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v5] driver core: enforce device_lock for driver_match_device()
Date: Wed, 21 Jan 2026 15:07:38 +0100 [thread overview]
Message-ID: <DFUBQTBJJ8N8.DK0KCGBTV1UL@kernel.org> (raw)
In-Reply-To: <aXDOg9YXqWyV3JTR@willie-the-truck>
On Wed Jan 21, 2026 at 2:02 PM CET, Will Deacon wrote:
> On Wed, Jan 21, 2026 at 01:50:52PM +0100, Danilo Krummrich wrote:
>> On Wed Jan 21, 2026 at 1:49 PM CET, Mark Brown wrote:
>> > On Wed, Jan 21, 2026 at 12:02:15PM +0100, Danilo Krummrich wrote:
>> >
>> >> I assume that this should resolve the problem (unless there are more drivers
>> >> that register drivers in probe()):
>> >
>> > This makes sense to me, I guess we can just fix any other instances as
>> > they arise. Will you send the patch?
>>
>> Yes, I will send it soon.
>
> Please make sure you cc Dmitry and Georgi when you do that.
Sure!
> I'm worried that you proposal means we run the probe code once per TBU, which
> looks like it will break.
It shouldn't change anything in this regard. It only changes when the
qcom_smmu_tbu_driver is registered, initcall vs probe() of another driver.
- Danilo
next prev parent reply other threads:[~2026-01-21 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALbr=LYt-MqGM0ua78Rt7M679WR9hNnk0Or-WrB2myZ=KhaN0w@mail.gmail.com>
[not found] ` <20260121085549.165428-1-akaieurus@gmail.com>
2026-01-21 10:40 ` [PATCH v5] driver core: enforce device_lock for driver_match_device() Danilo Krummrich
2026-01-21 11:02 ` Danilo Krummrich
2026-01-21 11:19 ` Greg KH
2026-01-21 12:49 ` Mark Brown
2026-01-21 12:50 ` Danilo Krummrich
2026-01-21 13:02 ` Will Deacon
2026-01-21 14:07 ` Danilo Krummrich [this message]
2026-01-21 13:03 ` Robin Murphy
2026-01-21 14:13 ` Danilo Krummrich
2026-01-21 13:22 ` Jiayue Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFUBQTBJJ8N8.DK0KCGBTV1UL@kernel.org \
--to=dakr@kernel.org \
--cc=Aishwarya.TCV@arm.com \
--cc=akaieurus@gmail.com \
--cc=broonie@kernel.org \
--cc=chenqiuji666@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=quic_c_gdjako@quicinc.com \
--cc=rafael@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox