From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8836AB9 for ; Wed, 8 Feb 2023 18:01:15 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id j23so2430007wra.0 for ; Wed, 08 Feb 2023 10:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=cg0MVG6I6Y76rF/CZvC25sdPVewyNWnsbfa7pgSc2FzuvBEF1nJRYSbvtTtvCpyBYJ HVLVtYnuT2OXWBj247C60aUx18fMk60nfUTiPvyx4vWWIhhiFEXg1o5dZyYT2/CaBTHP Rk2W5EmObgDHnqXG6uH8g+U60GFuUN5xmPtLp+yaC9KRyVxJF0lsGEdkb3hXs1k4BBWs iXNRGDCeD6nJQ4LykFmzgC8UAm19GyMoUamSPNDWn8i1D9ZOfuf2RdGy1ji+r3lnwDIr AagVGYdSSv5vJlQaz0Ywkho2nGWBLCoeb1NwcamBM2qwdKm8oT1IJM430mbbdShhBRYB BaSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=pEoAg+NiXTxzNM0bw8w5eOn10B0ABheizUqsZ01PUVYYVCEDOppZT4tG4KhYeFd971 NI4A2HggJeP3+ZXppZ/YEOPz6BhU+LhHmNhJh82sGlgyZENIN3uF5jrPHB1Nocn1EMao GQbqTl2YsMxgo7j15ZVYvZJ+SANk6P+98JqM8/Ph89v7o35ed66q0BsGTeXrl+YiZ1/K QVifWZ4vxyW8792Yawld05h2cVrdvt2kyWDSwnjljbFA4IhZgYL+wdKVcFpkJU0k1AhG 968nCYD92tqfAfTwYWUxVHGh3vFKyg38YkTz8ZVyUas+uGpInVF/UO+8D+G+eAphwgGR lRSg== X-Gm-Message-State: AO0yUKUER+mj6hDtO0mrV4mCc96qPY1Hm99Q1y4aRf1UROK9LczKA2qa aTJ7UpEjAHP0fuxxbg+MJc0cSQ== X-Google-Smtp-Source: AK7set+3IM5sAOEuhaAPwVF0OVGRlrlPx7WqR8A8ToS+qIOpKQFwoXaZmbDkTQkIZJClDWGbpxR0/g== X-Received: by 2002:adf:e80e:0:b0:2bf:f44b:7a29 with SMTP id o14-20020adfe80e000000b002bff44b7a29mr7118746wrm.40.1675879273302; Wed, 08 Feb 2023 10:01:13 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id l13-20020adffe8d000000b002bfbda53b98sm11081478wrr.35.2023.02.08.10.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 10:01:12 -0800 (PST) Date: Wed, 8 Feb 2023 18:01:07 +0000 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, Abhinav Kumar , Alyssa Rosenzweig , Andy Gross , Bjorn Andersson , Daniel Vetter , David Airlie , Dmitry Baryshkov , Hector Martin , Konrad Dybcio , Matthias Brugger , Rob Clark , Rob Herring , Sean Paul , Steven Price , Suravee Suthikulpanit , Sven Peter , Tomeu Vizoso , Yong Wu Subject: Re: [RFC PATCH 05/45] iommu/io-pgtable: Split io_pgtable structure Message-ID: References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-6-jean-philippe@linaro.org> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Mostafa, On Tue, Feb 07, 2023 at 12:16:12PM +0000, Mostafa Saleh wrote: > > +static inline size_t > > +iopt_unmap_pages(struct io_pgtable *iop, unsigned long iova, size_t pgsize, > > + size_t pgcount, struct iommu_iotlb_gather *gather) > > +{ > > + if (!iop->ops || !iop->ops->map_pages) > Should this be !iop->ops->unmap_pages? Oh right, good catch! Sorry about the size of this patch by the way. If we decide to keep this change I'll reduce it by first introducing these helpers and then splitting the structure in another patch. Thanks, Jean