From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295A52CA4 for ; Tue, 15 Nov 2022 20:39:58 +0000 (UTC) Received: by mail-qt1-f174.google.com with SMTP id cg5so9497549qtb.12 for ; Tue, 15 Nov 2022 12:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uFb9AkF5DsDUHSuCLnIVyedGIVQ0vSQgZz21yC2FixQ=; b=G5j57M07nAeUMUOvfKBIvtwuNdmKZr+ebSsapCXtIgkOPaL+d3y1f/cHlkniBZJiXf np4Mw+iFldQhTFQrmPllNufC8Hnlw6L5MY0dprWTkBjRCoXbGalIjjkgiaVl6q8G0whE n5RUvsblHzNjre5BtyuA482hj95moYLLPA83itnow+Ex5BIwlwrhopmb5li8HcABjJ88 7od4gmnh1lAl0z+8ZyPgi4psyqzRD91MueRGZPReY18HjBQ1bOw4q/xxmnWRYPq1CGcH Mh3Rp5dHC/EgGC32pJDZg7Dei9vg6XzkR4+IK6MkR0CdYPIlf4g+/WNdIiCKXY88/yCl NQJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uFb9AkF5DsDUHSuCLnIVyedGIVQ0vSQgZz21yC2FixQ=; b=znkoHNKbNieqyrDGJpucPdfjRdSWcmbnICMLaMv/W3iDVwBGYAd3Uvbu9qbqrPEfiD OTDMlrIA+sDG39HH4wg5bXQsJPltyL2zSTCCRi8p3DSxhHOdq+sb78uCJifWamCBd6En kabUqUtNlgs/gURwqQ9UYRsHYIdb09qLQ32Sa4IUwnjyX9ejWYGulH5caTR6wvEJ435e ENwapOTCTbpAKaZFt121CP5XNPXBzsrSwhqW/srgSxM6j/zxc/8vzl/lW52T+NVXsODh yoQswuFv88CNcWhlwAZ7mbEiOzjktn+E4C1VIfpnxTqudjfWjmL+7RhDsMzfaCBbdtlw JovA== X-Gm-Message-State: ANoB5pk7O4i0ZsJiOq9eJpmB5MxF0MVyCFPQyMlknBm11XZejWo8226p 99nfKT/mRU5tLNDxwvev33CsGw== X-Google-Smtp-Source: AA0mqf7wdmvUOx1k+YSFk7zHP4ga+BQ8+SSFpdbt7xHstSjZfXURNKfbLdLQzQd+eKDBS9SkIqI9YA== X-Received: by 2002:a05:622a:429b:b0:399:78b4:5771 with SMTP id cr27-20020a05622a429b00b0039978b45771mr18719839qtb.622.1668544797105; Tue, 15 Nov 2022 12:39:57 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id v14-20020a05620a440e00b006fba0a389a4sm1371576qkp.88.2022.11.15.12.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 12:39:56 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ov2ip-004k5T-H0; Tue, 15 Nov 2022 16:39:55 -0400 Date: Tue, 15 Nov 2022 16:39:55 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dennis Dalessandro , Mauro Carvalho Chehab , Alexandra Winter , Wenjia Zhang , Marek Szyprowski , Jaroslav Kysela , Takashi Iwai , Russell King , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/7] RDMA/hfi1: don't pass bogus GFP_ flags to dma_alloc_coherent Message-ID: References: <20221113163535.884299-1-hch@lst.de> <20221113163535.884299-3-hch@lst.de> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113163535.884299-3-hch@lst.de> On Sun, Nov 13, 2022 at 05:35:30PM +0100, Christoph Hellwig wrote: > dma_alloc_coherent is an opaque allocator that only uses the GFP_ flags > for allocation context control. Don't pass GFP_USER which doesn't make > sense for a kernel DMA allocation or __GFP_COMP which makes no sense > for an allocation that can't in any way be converted to a page pointer. > > Signed-off-by: Christoph Hellwig > --- > drivers/infiniband/hw/hfi1/init.c | 21 +++------------------ > 1 file changed, 3 insertions(+), 18 deletions(-) I have no idea what qib was trying to do here, but I'm fine if you take this through another tree Acked-by: Jason Gunthorpe Jason