From: Ashok Raj <ashok.raj@intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: <iommu@lists.linux.dev>, LKML <linux-kernel@vger.kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Yi Liu <yi.l.liu@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Raghunathan Srinivasan <raghunathan.srinivasan@intel.com>,
Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH] iommu/vt-d: Fix buggy QAT device mask
Date: Fri, 2 Dec 2022 17:41:19 -0800 [thread overview]
Message-ID: <Y4qpPxpXO9XQ2NEL@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <20221203005610.2927487-1-jacob.jun.pan@linux.intel.com>
On Fri, Dec 02, 2022 at 04:56:10PM -0800, Jacob Pan wrote:
> Impacted QAT device IDs that need extra dtlb flush quirk is ranging
> from 0x4940 to 0x4943. After bitwise AND device ID with 0xfffc the
> result should be 0x4940 instead of 0x494c to identify these devices.
Can you add the lore link for the original post here just for reference.
as a Link: tag, since this depends on the other patch.
>
> Reported-by: Raghunathan Srinivasan <raghunathan.srinivasan@intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> ---
> drivers/iommu/intel/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index d8759f445aff..0b10104c4b99 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1401,7 +1401,7 @@ static void domain_update_iotlb(struct dmar_domain *domain)
> * This quirk is exempted from risky_device() check because it applies only
> * to the built-in QAT devices and it doesn't grant additional privileges.
> */
> -#define BUGGY_QAT_DEVID_MASK 0x494c
> +#define BUGGY_QAT_DEVID_MASK 0x4940
> static bool dev_needs_extra_dtlb_flush(struct pci_dev *pdev)
> {
> if (pdev->vendor != PCI_VENDOR_ID_INTEL)
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-12-03 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 0:56 [PATCH] iommu/vt-d: Fix buggy QAT device mask Jacob Pan
2022-12-03 1:41 ` Ashok Raj [this message]
2022-12-05 16:29 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4qpPxpXO9XQ2NEL@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raghunathan.srinivasan@intel.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox