Re: [PATCH 3/3] iommu/virtio: Enable x86 support

Jean-Philippe Brucker
2021-04-15T15:15:43Z

On Thu, Mar 18, 2021 at 02:28:02PM -0400, Michael S. Tsirkin wrote:
> On Tue, Mar 16, 2021 at 08:16:54PM +0100, Jean-Philippe Brucker wrote:
> > With the VIOT support in place, x86 platforms can now use the
> > virtio-iommu.
> >
> > The arm64 Kconfig selects IOMMU_DMA, while x86 IOMMU drivers select it
> > themselves.
> >
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> > ---
> > drivers/iommu/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > index 2819b5c8ec30..ccca83ef2f06 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -400,8 +400,9 @@ config HYPERV_IOMMU
> > config VIRTIO_IOMMU
> > tristate "Virtio IOMMU driver"
> > depends on VIRTIO
> > - depends on ARM64
> > + depends on (ARM64 || X86)
> > select IOMMU_API
> > + select IOMMU_DMA if X86
>
> Would it hurt to just select unconditionally? Seems a bit cleaner
> ...

Yes I think I'll do this for the moment

Thanks,
Jean

>
> > select INTERVAL_TREE
> > select ACPI_VIOT if ACPI
> > help
> > --
> > 2.30.2