From: Joerg Roedel <joro@8bytes.org>
To: Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, Joerg Roedel <jroedel@suse.de>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Oza Pawandeep <poza@codeaurora.org>
Subject: Re: [PATCH] iommu/dma: Fix compile warning in 32-bit builds
Date: Mon, 7 Jun 2021 15:01:54 +0200 [thread overview]
Message-ID: <YL4Ywt5FcELNkx0t@8bytes.org> (raw)
In-Reply-To: <20210607124905.27525-1-joro@8bytes.org>
On Mon, Jun 07, 2021 at 02:49:05PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Compiling the recent dma-iommu changes under 32-bit x86 triggers this
> compile warning:
>
> drivers/iommu/dma-iommu.c:249:5: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘phys_addr_t’ {aka ‘unsigned int’} [-Wformat=]
>
> The reason is that %llx is used to print a variable of type
> phys_addr_t. Fix it by using the correct %pa format specifier for
> phys_addr_t.
>
> Cc: Srinath Mannam <srinath.mannam@broadcom.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Oza Pawandeep <poza@codeaurora.org>
> Fixes: aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address")
This tag is wrong, it should be:
Fixes: 9561dd434860 ("iommu/dma: Fix IOVA reserve dma ranges")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/dma-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index 95e7349ac3f1..5d96fcc45fec 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -246,8 +246,8 @@ static int iova_reserve_pci_windows(struct pci_dev *dev,
> } else if (end < start) {
> /* dma_ranges list should be sorted */
> dev_err(&dev->dev,
> - "Failed to reserve IOVA [%#010llx-%#010llx]\n",
> - start, end);
> + "Failed to reserve IOVA [%pa-%pa]\n",
> + &start, &end);
> return -EINVAL;
> }
>
> --
> 2.31.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2021-06-07 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 12:49 [PATCH] iommu/dma: Fix compile warning in 32-bit builds Joerg Roedel
2021-06-07 13:01 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL4Ywt5FcELNkx0t@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=poza@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=srinath.mannam@broadcom.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).