From: Joerg Roedel <joro@8bytes.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
iommu <iommu@lists.linux-foundation.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain()
Date: Wed, 9 Jun 2021 09:44:32 +0200 [thread overview]
Message-ID: <YMBxYKNjVGkQZJAH@8bytes.org> (raw)
In-Reply-To: <20210513075815.6382-1-thunder.leizhen@huawei.com>
On Thu, May 13, 2021 at 03:58:15PM +0800, Zhen Lei wrote:
> Function iommu_group_store_type() is the only caller of the static
> function iommu_change_dev_def_domain() and has performed
> "if (WARN_ON(!group))" detection before calling it. So the one here is
> redundant.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/iommu/iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 971068da67cb91d..8cdf6a1c4bfd773 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -3059,9 +3059,6 @@ static int iommu_change_dev_def_domain(struct iommu_group *group,
> int ret, dev_def_dom;
> struct device *dev;
>
> - if (!group)
> - return -EINVAL;
> -
> mutex_lock(&group->mutex);
>
> if (group->default_domain != group->domain) {
> --
> 2.26.0.106.g9fadedd
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2021-06-09 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 7:58 [PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain() Zhen Lei
2021-06-08 9:52 ` Will Deacon
2021-06-09 7:44 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMBxYKNjVGkQZJAH@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=sai.praneeth.prakhya@intel.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).