From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADFDC43214 for ; Mon, 26 Jul 2021 16:26:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0594E60F6B for ; Mon, 26 Jul 2021 16:26:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0594E60F6B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wantstofly.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B758340388; Mon, 26 Jul 2021 16:26:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7L0b8H2OkV0G; Mon, 26 Jul 2021 16:26:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8BA1840372; Mon, 26 Jul 2021 16:26:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 65773C0010; Mon, 26 Jul 2021 16:26:18 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 32782C000E for ; Mon, 26 Jul 2021 16:26:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 204996067C for ; Mon, 26 Jul 2021 16:26:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YRcIhzMj2vf8 for ; Mon, 26 Jul 2021 16:26:16 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.wantstofly.org (hmm.wantstofly.org [213.239.204.108]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3255A605F1 for ; Mon, 26 Jul 2021 16:26:15 +0000 (UTC) Received: by mail.wantstofly.org (Postfix, from userid 1000) id 635F97F46A; Mon, 26 Jul 2021 19:26:12 +0300 (EEST) Date: Mon, 26 Jul 2021 19:26:12 +0300 From: Lennert Buytenhek To: Joerg Roedel Subject: Re: [PATCH,RFC] iommu/amd: Use report_iommu_fault() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Jul 26, 2021 at 01:54:49PM +0200, Joerg Roedel wrote: > Hi Lennert, Hi Joerg, > On Mon, Jul 19, 2021 at 12:54:43PM +0300, Lennert Buytenhek wrote: > > + if (dev_data) { > > + int report_flags; > > + > > + /* > > + * AMD I/O Virtualization Technology (IOMMU) Specification, > > + * revision 3.00, section 2.5.3 ("IO_PAGE_FAULT Event") says > > + * that the RW ("read-write") bit is only valid if the I/O > > + * page fault was caused by a memory transaction request > > + * referencing a page that was marked present. > > + */ > > + report_flags = 0; > > + if ((flags & (EVENT_FLAG_TR | EVENT_FLAG_PR | EVENT_FLAG_I)) == > > + EVENT_FLAG_PR) { > > + if (flags & EVENT_FLAG_RW) > > + report_flags |= IOMMU_FAULT_WRITE; > > + else > > + report_flags |= IOMMU_FAULT_READ; > > + } > > + > > + if (!report_iommu_fault(&dev_data->domain->domain, > > + &pdev->dev, address, report_flags)) > > + goto out; > > + } > > I'd like to limit calling report_iommu_fault() to dma-faults and leave > IRQ remapping faults unreported. The IOMMU layer does not really care a > lot about IRQs and a potential domain handler will also not be prepared > to handler IRQ specific faults (there is no generic way to detect them). I'm sorry -- this appears to have been a stupid oversight on my part. New patch coming up. Thanks, Lennert _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu