From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5037CC43217 for ; Mon, 27 Sep 2021 20:41:52 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 094BD60EFD for ; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 094BD60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C491381000; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mIkM-bGd__A0; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id B9ACD80FF2; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 90D83C001C; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D90B3C000F for ; Mon, 27 Sep 2021 20:41:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BAE24404B6 for ; Mon, 27 Sep 2021 20:41:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MNNLvbAtxi4m for ; Mon, 27 Sep 2021 20:41:48 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9D2D8404B4 for ; Mon, 27 Sep 2021 20:41:48 +0000 (UTC) Received: by mail-ot1-x331.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso26073768otv.12 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=bNkfIe3LHEJWXZaSSGkm9f+M4hyzIr5S11g5NJm5HHTxkEjgoGnZSwn4W6xoewSmC5 EJ/kGdUBcDSKxUHP+LZ1vRdqVHu1lOZbHjpAbCsiF53Z0JFDQpSqcp62o7haf9cOzKy3 G3B1AGeKtOzct8ZRwA8YnQ7LDmZT2+8ysysSIn5H6OMekMdDGk9KSIeoZKaHZwvKk7hP YdrYsT9etjhy/sZh6yqtps3H5jT6vandROdmDHuIGVlHJRjPmIU8bBvJ1GR+GWa+lcSQ pn/XVZJricR+zrZIKxqfjD0iPMphbmpUzZHOo/B0SwLjxP2HDPDZ6I/+3/99aJLl8zoH k8ew== X-Gm-Message-State: AOAM533CJCtkxgr94lZkCt93HcYPYK6itKdm2hjz+Foku9bSvmyUTxUE e67F8J+imUlhQKESUHY1q9A6EQ== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Mark Rutland , Ulf Hansson , David Airlie , linux-wireless , Linus Walleij , dri-devel , ath10k@lists.infradead.org, Will Deacon , "open list:IOMMU DRIVERS" , Jernej Skrabec , Chen-Yu Tsai , Andy Gross , Linux ARM , Jakub Kicinski , linux-sunxi@lists.linux.dev, Linux Media Mailing List , Arnd Bergmann , linux-arm-msm , Maxime Ripard , "open list:GPIO SUBSYSTEM" , John Stultz , Mauro Carvalho Chehab , Sean Paul , Kalle Valo , Alex Elder , Networking , linux-mmc , Linux Kernel Mailing List , Daniel Vetter , Sudeep Holla , freedreno , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu