From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEF5C433EF for ; Wed, 13 Oct 2021 13:19:44 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA3AE610D0 for ; Wed, 13 Oct 2021 13:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA3AE610D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rosenzweig.io Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 98629825B1; Wed, 13 Oct 2021 13:19:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7kNSirzL40dj; Wed, 13 Oct 2021 13:19:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 918F482611; Wed, 13 Oct 2021 13:19:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4EE6EC0011; Wed, 13 Oct 2021 13:19:42 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 56575C000D for ; Wed, 13 Oct 2021 13:19:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 34716404D7 for ; Wed, 13 Oct 2021 13:19:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kr_ajr_PvL3c for ; Wed, 13 Oct 2021 13:19:39 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from rosenzweig.io (rosenzweig.io [138.197.143.207]) by smtp2.osuosl.org (Postfix) with ESMTPS id 118014018D for ; Wed, 13 Oct 2021 13:19:38 +0000 (UTC) Date: Wed, 13 Oct 2021 08:51:04 -0400 From: Alyssa Rosenzweig To: Wan Jiabing Subject: Re: [PATCH] iommu/dart: use kmemdup instead of kzalloc and memcpy Message-ID: References: <20211013063441.29888-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013063441.29888-1-wanjiabing@vivo.com> Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kael_w@yeah.net, Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Reviewed-by: Alyssa Rosenzweig On Wed, Oct 13, 2021 at 02:34:41AM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup > > Signed-off-by: Wan Jiabing > --- > drivers/iommu/apple-dart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 280ff8df728d..5eeb8d6b72e2 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -701,13 +701,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev) > if (!group) > goto out; > > - group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL); > + group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL); > if (!group_master_cfg) { > iommu_group_put(group); > goto out; > } > > - memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg)); > iommu_group_set_iommudata(group, group_master_cfg, > apple_dart_release_group); > > -- > 2.20.1 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu