From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96F86C433FE for ; Mon, 6 Dec 2021 14:13:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 39291403BE; Mon, 6 Dec 2021 14:13:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7WSO8jm5iEnD; Mon, 6 Dec 2021 14:13:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id B88E240339; Mon, 6 Dec 2021 14:13:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8F915C002F; Mon, 6 Dec 2021 14:13:29 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9ED0AC0012 for ; Mon, 6 Dec 2021 14:13:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8A5AD4034E for ; Mon, 6 Dec 2021 14:13:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7XbAWJd-t680 for ; Mon, 6 Dec 2021 14:13:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by smtp2.osuosl.org (Postfix) with ESMTPS id 189B14034B for ; Mon, 6 Dec 2021 14:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mC4snFvmVQItGI2siC8cGfUb3byxoiOnKLgqdbmyMcQ=; b=dm7wjbftIMFsPJba8CxJwPYFy6 uS4LcWXMZyawxLsDstv//jKrvkkHN+K8djaQ9PmBo+FuSeobcozb4MOeufoogygP0+rlwIkwY2/Lb YztWWXYFwjNwhu7BSLU7so/EDmhQJy5DJ4roZQzwr7AF355d551CeeJebeRRvGZYkQuhCs5bDRjFz iPECqpnqCnVu4wob3boG1SDiKIKEfKgCdXaDM7Jj/r+naHsJxe/6Kf/dg/9NIs5u7zEj8eQ7TLKDJ 00rvqUZ+3bx4d5MXtYgjsLNW7Kc4fFN1xevpOCSdinVsUvjOlriMW9vHzk7xfP83Aud2bNDDIOiI8 qjWDRv6g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1muEjl-004ADO-Gv; Mon, 06 Dec 2021 14:13:01 +0000 Date: Mon, 6 Dec 2021 06:13:01 -0800 From: Christoph Hellwig To: Greg Kroah-Hartman Subject: Re: [PATCH v3 03/18] driver core: platform: Rename platform_dma_configure() Message-ID: References: <20211206015903.88687-1-baolu.lu@linux.intel.com> <20211206015903.88687-4-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: Stuart Yoder , rafael@kernel.org, David Airlie , linux-pci@vger.kernel.org, Thierry Reding , Diana Craciun , Dmitry Osipenko , Will Deacon , Ashok Raj , Jonathan Hunter , Christoph Hellwig , Jason Gunthorpe , Kevin Tian , Chaitanya Kulkarni , Alex Williamson , kvm@vger.kernel.org, Bjorn Helgaas , Dan Williams , Cornelia Huck , linux-kernel@vger.kernel.org, Li Yang , iommu@lists.linux-foundation.org, Jacob jun Pan , Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Dec 06, 2021 at 08:53:07AM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 06, 2021 at 09:58:48AM +0800, Lu Baolu wrote: > > The platform_dma_configure() is shared between platform and amba bus > > drivers. Rename the common helper to firmware_dma_configure() so that > > both platform and amba bus drivers could customize their dma_configure > > callbacks. > > Please, if you are going to call these functions "firmware_" then move > them to the drivers/firmware/ location, they do not belong in > drivers/base/platform.c anymore, right? firmware seems rather misnamed anyway, amba doesn't reall have anything to do with "firmware". _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu