From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
Guoqing Jiang <guoqing.jiang@linux.dev>
Subject: Re: [PATCH 2/2] iommu/vt-d: Fix potential memory leak in intel_setup_irq_remapping()
Date: Mon, 31 Jan 2022 16:53:25 +0100 [thread overview]
Message-ID: <YfgF9Rl49aS2NNSS@8bytes.org> (raw)
In-Reply-To: <20220128031002.2219155-3-baolu.lu@linux.intel.com>
On Fri, Jan 28, 2022 at 11:10:02AM +0800, Lu Baolu wrote:
> From: Guoqing Jiang <guoqing.jiang@linux.dev>
>
> After commit e3beca48a45b ("irqdomain/treewide: Keep firmware node
> unconditionally allocated"). For tear down scenario, fn is only freed
> after fail to allocate ir_domain, though it also should be freed in case
> dmar_enable_qi returns error.
>
> Besides free fn, irq_domain and ir_msi_domain need to be removed as well
> if intel_setup_irq_remapping fails to enable queued invalidation.
>
> Improve the rewinding path by add out_free_ir_domain and out_free_fwnode
> lables per Baolu's suggestion.
>
> Fixes: e3beca48a45b ("irqdomain/treewide: Keep firmware node unconditionally allocated")
> Suggested-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> Link: https://lore.kernel.org/r/20220119063640.16864-1-guoqing.jiang@linux.dev
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/intel/irq_remapping.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Applied this one, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-01-31 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 3:10 [PATCH 0/2] iommu/vt-d: Fixes for v5.17-rc2 Lu Baolu
2022-01-28 3:10 ` [PATCH 1/2] iommu/vt-d: Fix PCI bus rescan device hot add Lu Baolu
2022-01-30 7:43 ` Joerg Roedel
2022-01-31 13:53 ` Robin Murphy
2022-01-31 15:52 ` Joerg Roedel
2022-02-01 19:19 ` Jacob Pan
2022-02-03 8:25 ` Joerg Roedel
2022-02-09 21:52 ` Jacob Pan
2022-02-14 10:31 ` Joerg Roedel
2022-02-01 18:55 ` Jacob Pan
2022-01-28 3:10 ` [PATCH 2/2] iommu/vt-d: Fix potential memory leak in intel_setup_irq_remapping() Lu Baolu
2022-01-31 15:53 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfgF9Rl49aS2NNSS@8bytes.org \
--to=joro@8bytes.org \
--cc=baolu.lu@linux.intel.com \
--cc=guoqing.jiang@linux.dev \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox