From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80D07C433EF for ; Wed, 30 Mar 2022 14:20:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 20C7441C86; Wed, 30 Mar 2022 14:20:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BjT8gctwn7zh; Wed, 30 Mar 2022 14:20:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id C48D441C85; Wed, 30 Mar 2022 14:20:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A435BC002C; Wed, 30 Mar 2022 14:20:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13848C0012 for ; Wed, 30 Mar 2022 14:20:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 021D58479E for ; Wed, 30 Mar 2022 14:20:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ejNO8DhXWl3Q for ; Wed, 30 Mar 2022 14:20:19 +0000 (UTC) X-Greylist: delayed 00:19:37 by SQLgrey-1.8.0 Received: from muru.com (muru.com [72.249.23.125]) by smtp1.osuosl.org (Postfix) with ESMTP id C51DF8479A for ; Wed, 30 Mar 2022 14:20:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1504180FA; Wed, 30 Mar 2022 13:58:34 +0000 (UTC) Date: Wed, 30 Mar 2022 17:00:39 +0300 From: Tony Lindgren To: Lu Baolu Subject: Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred Message-ID: References: <20220216025249.3459465-1-baolu.lu@linux.intel.com> <20220216025249.3459465-9-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220216025249.3459465-9-baolu.lu@linux.intel.com> Cc: regressions@lists.linux.dev, David Airlie , Thierry Reding , Will Deacon , Christoph Hellwig , Ashok Raj , Jonathan Hunter , Christoph Hellwig , Ben Skeggs , Jason Gunthorpe , Kevin Tian , Alex Williamson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jacob jun Pan , Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi, * Lu Baolu [700101 02:00]: > The is_attach_deferred iommu_ops callback is a device op. The domain > argument is unnecessary and never used. Remove it to make code clean. Looks like this causes a regression for at least drivers/iommu/omap-iommu.c. To me it seems the issue is there is no is_attach_deferred implemented, so we get a NULL pointer dereference at virtual address 00000008: __iommu_probe_device from probe_iommu_group+0x2c/0x38 probe_iommu_group from bus_for_each_dev+0x74/0xbc bus_for_each_dev from bus_iommu_probe+0x34/0x2e8 bus_iommu_probe from bus_set_iommu+0x80/0xc8 bus_set_iommu from omap_iommu_init+0x88/0xcc omap_iommu_init from do_one_initcall+0x44/0x24c Any ideas for a fix? It would be good to fix this quickly so we don't end up with a broken v5.18-rc1.. For reference, this is mainline commit 41bb23e70b50 ("iommu: Remove unused argument in is_attach_deferred"). Regards, Tony #regzbot ^introduced 41bb23e70b50 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu