From: Christoph Hellwig <hch@infradead.org>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: will@kernel.org, jon@solid-run.com, linuxarm@huawei.com,
steven.price@arm.com, hch@infradead.org,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
wanghuiqiang@huawei.com, guohanjun@huawei.com,
Sami.Mujawar@arm.com, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 1/9] iommu: Introduce a union to struct iommu_resv_region
Date: Wed, 20 Apr 2022 23:46:24 -0700 [thread overview]
Message-ID: <YmD9wBhR8/j8HOaX@infradead.org> (raw)
In-Reply-To: <20220420164836.1181-2-shameerali.kolothum.thodi@huawei.com>
On Wed, Apr 20, 2022 at 05:48:28PM +0100, Shameer Kolothum wrote:
> @@ -141,6 +149,11 @@ struct iommu_resv_region {
> size_t length;
> int prot;
> enum iommu_resv_type type;
> + union {
> + struct iommu_iort_rmr_data rmr;
> + } fw_data;
> + void (*resv_region_free_fw_data)(struct device *dev,
> + struct iommu_resv_region *region);
I'd shorten the name to just free. Also any reason the call to this
method isn't also added in this patch as it logically belongs here?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-04-21 6:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 16:48 [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Shameer Kolothum via iommu
2022-04-20 16:48 ` [PATCH v10 1/9] iommu: Introduce a union to struct iommu_resv_region Shameer Kolothum via iommu
2022-04-21 6:46 ` Christoph Hellwig [this message]
2022-04-20 16:48 ` [PATCH v10 2/9] ACPI/IORT: Make iort_iommu_msi_get_resv_regions() return void Shameer Kolothum via iommu
2022-04-21 6:44 ` Christoph Hellwig
2022-04-20 16:48 ` [PATCH v10 3/9] ACPI/IORT: Provide a generic helper to retrieve reserve regions Shameer Kolothum via iommu
2022-04-21 6:44 ` Christoph Hellwig
2022-04-20 16:48 ` [PATCH v10 4/9] ACPI/IORT: Add support to retrieve IORT RMR reserved regions Shameer Kolothum via iommu
2022-04-21 6:48 ` Christoph Hellwig
2022-04-21 14:50 ` Shameerali Kolothum Thodi via iommu
2022-04-20 16:48 ` [PATCH v10 5/9] ACPI/IORT: Add a helper to retrieve RMR info directly Shameer Kolothum via iommu
2022-04-20 16:48 ` [PATCH v10 6/9] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum via iommu
2022-04-20 16:48 ` [PATCH v10 7/9] iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force bypass Shameer Kolothum via iommu
2022-04-20 16:48 ` [PATCH v10 8/9] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum via iommu
2022-04-20 16:48 ` [PATCH v10 9/9] iommu/arm-smmu: Get associated RMR info and install bypass SMR Shameer Kolothum via iommu
2022-04-21 12:58 ` [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Steven Price
2022-04-21 14:43 ` Shameerali Kolothum Thodi via iommu
2022-04-21 15:45 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmD9wBhR8/j8HOaX@infradead.org \
--to=hch@infradead.org \
--cc=Sami.Mujawar@arm.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=wanghuiqiang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox