From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v1 3/7] iommu/amd: Fix sparse warning
Date: Thu, 23 Jun 2022 13:30:35 +0200 [thread overview]
Message-ID: <YrRO21AvsFioAROB@8bytes.org> (raw)
In-Reply-To: <82767d0d-a04b-4432-0e7e-77bcca095e09@arm.com>
On Thu, Jun 23, 2022 at 10:42:52AM +0100, Robin Murphy wrote:
> TBH it's probably time to retire iommu_ops->pgsize_bitmap anyway. At the
> very least it would be logical to move it to iommu_domain_ops now, but maybe
> we could skip ahead and just rely on drivers initialising
> domain->pgsize_bitmap directly in their .domain_alloc?
>
> (and FWIW I'm leaning towards the same for the domain->ops as well; the more
> I look at ops->default_domain_ops, the more it starts looking like a stupid
> mess... my stupid mess... sorry about that)
Good idea, that would be even better.
Thanks,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-06-23 11:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 11:21 [PATCH v1 0/7] iommu/amd: Add Generic IO Page Table Framework Support for v2 Page Table Vasant Hegde via iommu
2022-06-03 11:21 ` [PATCH v1 1/7] iommu/amd: Refactor amd_iommu_domain_enable_v2 Vasant Hegde via iommu
2022-06-03 11:21 ` [PATCH v1 2/7] iommu/amd: Update sanity check when enable PRI/ATS Vasant Hegde via iommu
2022-06-03 11:21 ` [PATCH v1 3/7] iommu/amd: Fix sparse warning Vasant Hegde via iommu
2022-06-23 8:03 ` Joerg Roedel
2022-06-23 9:42 ` Robin Murphy
2022-06-23 11:30 ` Joerg Roedel [this message]
2022-06-27 10:29 ` Vasant Hegde via iommu
2022-07-13 4:07 ` Vasant Hegde
2022-07-15 11:32 ` Robin Murphy
2022-06-03 11:21 ` [PATCH v1 4/7] iommu/amd: Initial support for AMD IOMMU v2 page table Vasant Hegde via iommu
2022-06-23 8:09 ` Joerg Roedel
2022-06-03 11:21 ` [PATCH v1 5/7] iommu/amd: Add support for Guest IO protection Vasant Hegde via iommu
2022-06-03 11:21 ` [PATCH v1 6/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API Vasant Hegde via iommu
2022-06-03 11:21 ` [PATCH v1 7/7] iommu/amd: Introduce amd_iommu_pgtable command-line option Vasant Hegde via iommu
2022-06-23 8:12 ` Joerg Roedel
2022-06-28 7:53 ` Vasant Hegde via iommu
2022-07-06 9:11 ` Joerg Roedel
2022-06-23 8:15 ` [PATCH v1 0/7] iommu/amd: Add Generic IO Page Table Framework Support for v2 Page Table Joerg Roedel
2022-06-28 9:05 ` Vasant Hegde via iommu
2022-07-06 9:14 ` Joerg Roedel
2022-07-13 3:07 ` Suthikulpanit, Suravee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrRO21AvsFioAROB@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=robin.murphy@arm.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).