From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>, Yu Zhao <yuzhao@google.com>,
stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH 5.19 319/365] swiotlb: panic if nslabs is too small
Date: Wed, 24 Aug 2022 08:56:02 +0200 [thread overview]
Message-ID: <YwXLgq94hSd1TTak@kroah.com> (raw)
In-Reply-To: <c49d3b2b-9f5a-4257-9085-f7ac107cff40@oracle.com>
On Tue, Aug 23, 2022 at 10:25:27AM -0700, Dongli Zhang wrote:
> Adding Robin, Yu and swiotlb list.
>
> Hi Greg,
>
> There is an on-going discussion whether to revert this patch, because it breaks
> a corner case in MIPS when many kernel CONFIGs are not enabled (related to PCI
> and device). As a result, MIPS pre-allocates only PAGE_SIZE buffer as swiotlb.
>
> https://lore.kernel.org/all/20220820012031.1285979-1-yuzhao@google.com/
>
> However, the core idea of the patch is to panic on purpose if the swiotlb is
> configured with <1MB memory, in order to sync with the remap failure handler in
> swiotlb_init_remap().
Ok, I've dropped it from the 5.19 queue now. If you want it added to a
future kernel release, just resend it.
thanks,
greg k-h
prev parent reply other threads:[~2022-08-24 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220823080118.128342613@linuxfoundation.org>
[not found] ` <20220823080131.532813281@linuxfoundation.org>
2022-08-23 17:25 ` [PATCH 5.19 319/365] swiotlb: panic if nslabs is too small Dongli Zhang
2022-08-23 17:51 ` Yu Zhao
2022-08-23 18:22 ` Dongli Zhang
2022-08-24 6:56 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwXLgq94hSd1TTak@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dongli.zhang@oracle.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox