From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5E1CDF43 for ; Wed, 3 May 2023 19:09:40 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1a516fb6523so54293535ad.3 for ; Wed, 03 May 2023 12:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683140980; x=1685732980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=m2prCTdjzaiRiaqQtudLpWKutHCUVL/OSWsxsk3W0H0=; b=DgGf/RDPAqWGHut8/ffMPgzzhFJ9XYYSPgLBeni/aHHvM33hoTyZ2z1/iWZrJfEq83 XC8cOYLwo2w4awuIxnl0cMADE/m0XmY+wPpkMbjZhRe/h0OTU4R7JHORw6cp3ebvPJPs fVMtj4scXOewOp4pOg6Y+bLDbTCONtNkC6uKe3XQm4/tjkELGZ7bx+BlGycvwgcMZTg3 diw26d57mAXbzMIEL2R9owFYzXiYqv54fGxd86cbz1pWBKa8UI2AhEJ1f1/yiknBF/PK kJgW8kCwMV9OQVIdn/sPBvqc9vOmLsLdyI/c/vfOx43vpU0ufO13PA0zEYN9tJjBA8qt Rc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683140980; x=1685732980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m2prCTdjzaiRiaqQtudLpWKutHCUVL/OSWsxsk3W0H0=; b=ViIfgA+UnBu3dofaen6uNkCTUAmNAmMEgz9QYOa6ypUsL1o4SsJhNlb4lYBHb+Vqpt FjTimf/P4wJBRF2qaFoa9J0wUsGv3TDo4ffrZABEgRiJOQCA4qJYGVTgx9RH5DA5P9yM 4JzdojzIz5lJC2Lg1x2dJx9stT0uLcVPlH+a+/JQzU2WJGlnPiKnKu2x88MApT4Oim69 ogjqF8/IgVOYJBDE0oZNJLys9Gh9mldq/sY/G0/t1UNvSHLVgs4lkUVYeiAJ84o9rltE jPuN8/Ug31dueE8gRKNS9ErDx1CRJWOUxrsATBRD/uAhzXmoMgNqw5HWZn0+J+BbA3nu j5gQ== X-Gm-Message-State: AC+VfDzwBBVArSOb7vnGx4iTFdNKOY6it9r/Wk9+7waXPP01fCTY0866 wCJL+egfw4Kcos9B1fOMUT8= X-Google-Smtp-Source: ACHHUZ6YDYrRsQdW8TjDTlSuUDEQ8ByWIKmmy8KfjMdCubXv22qMvWwsp2IFNMqrmPGjqUc8LtNL9Q== X-Received: by 2002:a17:902:8d8a:b0:1ab:5b0:6f16 with SMTP id v10-20020a1709028d8a00b001ab05b06f16mr1059467plo.43.1683140979705; Wed, 03 May 2023 12:09:39 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6454]) by smtp.gmail.com with ESMTPSA id 12-20020a170902c24c00b001a69d1bc32csm21999335plg.238.2023.05.03.12.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 12:09:39 -0700 (PDT) Sender: Tejun Heo Date: Wed, 3 May 2023 09:09:37 -1000 From: Tejun Heo To: Kent Overstreet Cc: Johannes Weiner , Michal Hocko , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko Subject: Re: [PATCH 00/40] Memory allocation profiling Message-ID: References: <20230503180726.GA196054@cmpxchg.org> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 03, 2023 at 08:58:51AM -1000, Tejun Heo wrote: > On Wed, May 03, 2023 at 02:56:44PM -0400, Kent Overstreet wrote: > > On Wed, May 03, 2023 at 08:40:07AM -1000, Tejun Heo wrote: > > > > Yeah, easy / default visibility argument does make sense to me. > > > > > > So, a bit of addition here. If this is the thrust, the debugfs part seems > > > rather redundant, right? That's trivially obtainable with tracing / bpf and > > > in a more flexible and performant manner. Also, are we happy with recording > > > just single depth for persistent tracking? > > > > Not sure what you're envisioning? > > > > I'd consider the debugfs interface pretty integral; it's much more > > discoverable for users, and it's hardly any code out of the whole > > patchset. > > You can do the same thing with a bpftrace one liner tho. That's rather > difficult to beat. Ah, shit, I'm an idiot. Sorry. I thought allocations was under /proc and allocations.ctx under debugfs. I meant allocations.ctx is redundant. Thanks. -- tejun