From: Joerg Roedel <joro@8bytes.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] iommu/ipmmu-vmsa: Allow PCIe devices
Date: Mon, 22 May 2023 17:30:47 +0200 [thread overview]
Message-ID: <ZGuKp2hPnkJ6hy6B@8bytes.org> (raw)
In-Reply-To: <20230426082511.3621484-1-yoshihiro.shimoda.uh@renesas.com>
On Wed, Apr 26, 2023 at 05:25:11PM +0900, Yoshihiro Shimoda wrote:
> To allow PCIe devices, add a new condition whether the device is
> a PCI device or not in the ipmmu_device_is_allowed().
This needs more explanation on why PCI devices are safe to be allowed.
Without this context it looks just too dangerous.
Regards,
Joerg
next prev parent reply other threads:[~2023-05-22 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 8:25 [PATCH v2] iommu/ipmmu-vmsa: Allow PCIe devices Yoshihiro Shimoda
2023-05-22 15:30 ` Joerg Roedel [this message]
2023-05-29 4:58 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGuKp2hPnkJ6hy6B@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux.dev \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox