From: Jason Gunthorpe <jgg@ziepe.ca>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Vasant Hegde <vasant.hegde@amd.com>,
iommu@lists.linux.dev, joro@8bytes.org,
suravee.suthikulpanit@amd.com,
Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Subject: Re: [PATCH v2 iommu/next] iommu: Fix default domain setup
Date: Tue, 20 Jun 2023 08:42:41 -0300 [thread overview]
Message-ID: <ZJGQsWXkgTuj7xC1@ziepe.ca> (raw)
In-Reply-To: <13d072e5-df86-d3c8-6742-e52b66fd96a4@linux.intel.com>
On Tue, Jun 20, 2023 at 02:31:43PM +0800, Baolu Lu wrote:
> > err_restore:
> > if (old_dom) {
> > __iommu_group_set_domain_internal(
> > group, old_dom, IOMMU_SET_DOMAIN_MUST_SUCCEED);
> > + group->default_domain = old_dom;
> > iommu_domain_free(dom);
> > old_dom = NULL;
> > }
>
> The err_restore branch doesn't work if old_dom is NULL. We have no means
> to restore a group from a successful first-time attaching to NULL
> attaching.
Yes, this is what I fixed in my alternative version
Jason
next prev parent reply other threads:[~2023-06-20 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 8:49 [PATCH v2 iommu/next] iommu: Fix default domain setup Vasant Hegde
2023-06-19 11:31 ` Jason Gunthorpe
2023-06-20 5:11 ` Vasant Hegde
2023-06-20 6:31 ` Baolu Lu
2023-06-20 11:42 ` Jason Gunthorpe [this message]
2023-06-22 4:59 ` Vasant Hegde
2023-06-22 13:55 ` Jason Gunthorpe
2023-06-23 3:08 ` Baolu Lu
2023-06-23 4:38 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJGQsWXkgTuj7xC1@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=dheerajkumar.srivastava@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox