From: Jason Gunthorpe <jgg@nvidia.com>
To: Pengfei Xu <pengfei.xu@intel.com>
Cc: iommu@lists.linux.dev, baolu.lu@linux.intel.com,
kevin.tian@intel.com, nicolinc@nvidia.com, heng.su@intel.com,
rafael.j.wysocki@intel.com, lenb@kernel.org, lkp@intel.com
Subject: Re: [Syzkaller & bisect] There is general protection fault in iommu_device_unlink in upstream patch
Date: Wed, 2 Aug 2023 21:21:58 -0300 [thread overview]
Message-ID: <ZMrzJgoQfQFUT7AX@nvidia.com> (raw)
In-Reply-To: <ZMkMt1cTeXhg8yBM@xpf.sh.intel.com>
On Tue, Aug 01, 2023 at 09:46:31PM +0800, Pengfei Xu wrote:
> Hi Jason,
>
> Greeting!
>
> We tested the intel internal kernel and found that:
> There was general protection fault in iommu_device_unlink issue in kernel
> and found the problem commit:
> 14891af3799e iommu: Move the iommu driver sysfs setup into iommu_init/deinit_device()
>
> Above commit is same as following patch:
> https://lore.kernel.org/linux-iommu/6-v3-328044aa278c+45e49-iommu_probe_jgg@nvidia.com/
>
> All detailed info: https://github.com/xupengfe/syzkaller_logs/tree/main/230801_150257_iommu_device_unlink
> Reproduced code: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/repro.c
> Kconfig: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/kconfig_origin
> repro.prog: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/repro.prog
> repro.report: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/repro.report
> Bisect info: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/bisect_info.log
> Issue dmesg: https://github.com/xupengfe/syzkaller_logs/blob/main/230801_150257_iommu_device_unlink/a3fe9a2e1692a413d887a6a0f1184c26481d6a2b_dmesg.log
This is only an issue for the iommufd selftest and it looks very hard
to fix in a micro way.
Fortunately I already fixed it here:
https://lore.kernel.org/linux-iommu/15-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com
If Joerg doesn't take that series for this cycle I'll feed the above
patch through the iommufd tree to fix this.
Thanks,
Jason
next prev parent reply other threads:[~2023-08-03 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 13:46 [Syzkaller & bisect] There is general protection fault in iommu_device_unlink in upstream patch Pengfei Xu
2023-08-02 7:53 ` Baolu Lu
2023-08-02 12:26 ` Jason Gunthorpe
2023-08-03 0:21 ` Jason Gunthorpe [this message]
2023-08-03 1:04 ` Pengfei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMrzJgoQfQFUT7AX@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=heng.su@intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=lenb@kernel.org \
--cc=lkp@intel.com \
--cc=nicolinc@nvidia.com \
--cc=pengfei.xu@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox