From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Zhang, Tina" <tina.zhang@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Michael Shavit <mshavit@google.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] iommu: Add mm_get_pasid() helper function
Date: Wed, 9 Aug 2023 09:31:16 -0300 [thread overview]
Message-ID: <ZNOHFKbkQ75owuwC@ziepe.ca> (raw)
In-Reply-To: <BN9PR11MB527654AF38084B07EC7734468C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
On Wed, Aug 09, 2023 at 09:47:15AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@ziepe.ca>
> > Sent: Tuesday, August 8, 2023 11:02 PM
> >
> > On Tue, Aug 08, 2023 at 03:49:40PM +0800, Tina Zhang wrote:
> > > mm_get_pasid() is for getting mm pasid value.
> > >
> > > The motivation is to replace mm->pasid with an iommu private data
> > > structure that is introduced in a later patch.
> >
> > Maybe we should start out by calling it what it actually is:
> >
> > 'mm_get_enqcmd_pasid()'
> >
> > We can't actually have multiple SVA domains with different PASIDs
> > until the places wrongly calling this are removed :\
> >
>
> it's kind of egg-chicken problem. mm_get_pasid() is used by all SVA
> scenarios beyond enqcmd then calling it mm_get_enqcmd_pasid()
> also sounds weird for non-enqcmd case.
Well, those are wrong. We need to be fixing them not hide our eyes to
the wrongness.
Michael is cooking a fix for ARM, Tina should come with a fix for
Intel in this series.
Jason
next prev parent reply other threads:[~2023-08-09 12:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 7:49 [PATCH 0/5] Share sva domains with all devices bound to a mm Tina Zhang
2023-08-08 7:49 ` [PATCH 1/5] iommu: Add mm_get_pasid() helper function Tina Zhang
2023-08-08 15:02 ` Jason Gunthorpe
2023-08-09 0:31 ` Baolu Lu
2023-08-09 9:47 ` Tian, Kevin
2023-08-09 12:31 ` Jason Gunthorpe [this message]
2023-08-08 7:49 ` [PATCH 2/5] iommu: Call helper function to get assigned pasid value Tina Zhang
2023-08-09 0:21 ` Baolu Lu
2023-08-09 9:49 ` Tian, Kevin
2023-08-09 10:58 ` Baolu Lu
2023-08-09 14:48 ` Jason Gunthorpe
2023-08-10 1:37 ` Baolu Lu
2023-08-10 16:30 ` Jason Gunthorpe
2023-08-09 12:35 ` Jason Gunthorpe
2023-08-10 7:52 ` Tian, Kevin
2023-08-10 16:36 ` Jason Gunthorpe
2023-08-11 3:18 ` Tian, Kevin
2023-08-08 7:49 ` [PATCH 3/5] mm: Add structure to keep sva information Tina Zhang
2023-08-08 7:49 ` [PATCH 4/5] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2023-08-08 15:12 ` Jason Gunthorpe
2023-08-08 15:19 ` Jason Gunthorpe
2023-08-10 2:14 ` Tina Zhang
2023-08-08 7:49 ` [PATCH 5/5] mm: Deprecate pasid field Tina Zhang
2023-08-09 0:18 ` [PATCH 0/5] Share sva domains with all devices bound to a mm Baolu Lu
2023-08-09 9:44 ` Tian, Kevin
2023-08-09 10:51 ` Baolu Lu
2023-08-11 1:06 ` Tina Zhang
2023-08-09 14:46 ` Jason Gunthorpe
2023-08-10 1:23 ` Baolu Lu
2023-08-10 7:44 ` Tian, Kevin
2023-08-09 9:41 ` Tian, Kevin
2023-08-10 1:31 ` Tina Zhang
2023-08-10 7:49 ` Tian, Kevin
2023-08-10 16:27 ` Jason Gunthorpe
2023-08-11 1:12 ` Tina Zhang
2023-08-11 1:07 ` Tina Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNOHFKbkQ75owuwC@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox