From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281171F95D for ; Thu, 10 Aug 2023 19:02:45 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-76cab6fe9c0so104006285a.0 for ; Thu, 10 Aug 2023 12:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1691694165; x=1692298965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ol8o111D6X16s4/vdk4snMP1jvmYUyrjvsKNZNa6i6w=; b=j8xQ5etaEWczcx0UpChvNBhWH4pGMmMqfPSDxt8lVA94h4iCSj/YmaLHgsOzPIgTtJ Ee00wZmKsoZRTdPbpngP3tdhd7Lzj1EsL3h4a+z/JQh5bZjk/le27wTBDpyMlffdee3q 1y7utSBEMRegnuHGC1K83jeW7N5jQocQv471zdiA7pNJJafQk/neRBMwPkjM+uzfUkqG wUI7nzmUMCP85you7O/gAEwhzYjpUypvAVIppJ17U/qxfotuNv1pQ0XDLhHy1baFJz1P xFf/ny3SyCb9bWjFwRiX5zAd3JxZ4WPny/ZCy0SVOSI3C43c0gXWVIaJuQhIhuPpJSif zrYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691694165; x=1692298965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ol8o111D6X16s4/vdk4snMP1jvmYUyrjvsKNZNa6i6w=; b=SGomsP/WEZPRAucprZq2Y7mlQ0XRK5/tlJchfl+qOS/PrrcS5gMwzRqcHkUQoeLNBB xFeJOLHDCni5xgQY0wf/4p2fhpEWTLavIkjDGQLWjVwmh/GGAhCMMhGxgX9WuWEPZp6q iprzGUWCXd2hG0sHkO/mpKT1ZkFbOaHoDH3+DA9XuhozNOhfXmTUwZ1m8qygwJtnv02b DBShL++WcXciomDmApQU0tW7GqJJFTkoU4XwskjUN9vQVpVedBJPPKDXb2Vr1PtgqUvk VOHpXFPq+62y0YSrplCbLiGJHOmwHPdyl7v6w+WrQsmko1auiQaA+KtYFq9a7ldyJ5y7 5EfQ== X-Gm-Message-State: AOJu0YyrZ67hJ6Nri6jMkSnhz4szna2zuvHGz7lCpMwH8wbANEPWaJNW Zo+qi6F5RoTUW5mGgPmjG8uX/g== X-Google-Smtp-Source: AGHT+IGGfaalbPDlT+pvMJOgJl26XLZ6gib9ghHzXbB7fd+R8Fp1mS7Fgm+I9bVdGlHSgzCGUXGaAw== X-Received: by 2002:a05:620a:4412:b0:765:a9d7:2ca2 with SMTP id v18-20020a05620a441200b00765a9d72ca2mr4080265qkp.48.1691694164969; Thu, 10 Aug 2023 12:02:44 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id g3-20020ae9e103000000b0076cda271e54sm680981qkm.112.2023.08.10.12.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 12:02:44 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qUAvj-005Ihx-JK; Thu, 10 Aug 2023 16:02:43 -0300 Date: Thu, 10 Aug 2023 16:02:43 -0300 From: Jason Gunthorpe To: Lu Baolu Cc: Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/12] iommu: Move iopf_handler() to iommu-sva.c Message-ID: References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-10-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727054837.147050-10-baolu.lu@linux.intel.com> On Thu, Jul 27, 2023 at 01:48:34PM +0800, Lu Baolu wrote: > The iopf_handler() function handles a fault_group for a SVA domain. Move > it to the right place. > > Signed-off-by: Lu Baolu > --- > drivers/iommu/iommu-sva.h | 17 +++++++++++++ > drivers/iommu/io-pgfault.c | 50 +++----------------------------------- > drivers/iommu/iommu-sva.c | 49 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 47 deletions(-) > diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c > index 05c0fb2acbc4..ab42cfdd7636 100644 > --- a/drivers/iommu/iommu-sva.c > +++ b/drivers/iommu/iommu-sva.c > @@ -219,3 +219,52 @@ void mm_pasid_drop(struct mm_struct *mm) > +static void iopf_handler(struct work_struct *work) > +{ > + struct iopf_fault *iopf; > + struct iopf_group *group; > + struct iommu_domain *domain; > + enum iommu_page_response_code status = IOMMU_PAGE_RESP_SUCCESS; > + > + group = container_of(work, struct iopf_group, work); > + domain = iommu_get_domain_for_dev_pasid(group->dev, > + group->last_fault.fault.prm.pasid, 0); > + if (!domain || !domain->iopf_handler) > + status = IOMMU_PAGE_RESP_INVALID; > + > + list_for_each_entry(iopf, &group->faults, list) { > + /* > + * For the moment, errors are sticky: don't handle subsequent > + * faults in the group if there is an error. > + */ > + if (status == IOMMU_PAGE_RESP_SUCCESS) > + status = domain->iopf_handler(&iopf->fault, > + domain->fault_data); > + } > + > + iopf_complete_group(group->dev, &group->last_fault, status); > + iopf_free_group(group); > +} Routing faults to domains is generic code, not SVA code. SVA starts at domain->iopf_handler Jason