From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <iommu@lists.linux.dev>, Kevin Tian <kevin.tian@intel.com>,
Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH] iommufd: Organize the mock domain alloc functions closer to Joerg's tree
Date: Mon, 30 Oct 2023 17:26:54 -0700 [thread overview]
Message-ID: <ZUBJznfex9OY8ciz@Asurada-Nvidia> (raw)
In-Reply-To: <0-v1-90a855762c96+19de-mock_merge_jgg@nvidia.com>
On Mon, Oct 30, 2023 at 07:53:26PM -0300, Jason Gunthorpe wrote:
> Patches in Joerg's iommu tree to convert the mock driver to use
> domain_alloc_paging() that clash badly with the way the selftest changes
> for nesting were structured.
>
> Massage the selftest so that it looks closer the code after the
> domain_alloc_paging() conversion to ease the merge. Change
> __mock_domain_alloc_paging() into mock_domain_alloc_paging() in the same
> way as the iommu tree. The merge resolution then trivially takes both and
> deletes mock_domain_alloc().
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
The change itself looks good, though I don't see much difference
by experimenting git-merge with and without this change..
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
next prev parent reply other threads:[~2023-10-31 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 22:53 [PATCH] iommufd: Organize the mock domain alloc functions closer to Joerg's tree Jason Gunthorpe
2023-10-31 0:26 ` Nicolin Chen [this message]
2023-10-31 2:14 ` Tian, Kevin
2023-10-31 4:13 ` Yi Liu
2023-10-31 11:30 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUBJznfex9OY8ciz@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox