From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6766A27978F for ; Tue, 15 Apr 2025 22:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744755324; cv=none; b=Szf+3xLhahaXtXYjqZybm/SDVO2gTQulRcLalCkZEnov2VHDZK6hae1qwMWFW7TiUzqxygpy7biMfw0G2lePIHn+X7uK2R1x7XVdnA6GExbA1Nl0WKkHWYizrXQDNNb+F+JhJBmp7Kh1Zs7nd7zw4YBXdPDiMrIocCafpDk4H7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744755324; c=relaxed/simple; bh=wiubO1rowJJ7Bd/abC83QrnLeIgusBUrsszAL9POhpQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MJdh9PLQcfNaL/W2L/u2Ndcy6Ss5DonPS4NGEiPf8525r1wvW1tHubxwTI1ey0Jf1AB1qMQy3C1VaH9uxr8ChK9F2ZN6jzdDCjW0gVN9J72lR/oNAQ7wGHZF/dLFnVFVplhUumEBbmwh5M0iOmDT4rT/mm0XbelDnqqhvAQa+R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=3P3Ou+8T; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="3P3Ou+8T" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-af91ea9e885so5046454a12.3 for ; Tue, 15 Apr 2025 15:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744755322; x=1745360122; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Ry9xEwNaBzqQYPUr2sJCAn+hzw6WkQUhzGrae9Rjk7I=; b=3P3Ou+8TpRg1voQfJxepqFXIgmICDK6G1oihUFmHsq0LgREOSMku1YvgApqGkx8NMS gUAoWRZAZT3zr6H1tb7XrfnCUtsnb0QOvbaN2JkUlIZcq5y5twmgAFyXD9fpuMqlRGLB XODUEGDz715x8/FjxYBI6ZRd4bnKpmcKMior2zw77UYWZIS4l4z3v+OncTHkJpThJ+Em TmJRaFB4ijkKkolKiKmVurGKqDrptPs6MTwXbkL0kxSvFG/CXiNB2uaLzbWFb7eTJhQH 6rUgKDVmwHQ1Iunlkl29XG/pifDmQ41nWO0cQbrydSWUB5tqL3Fl3v+zwdF4YYC18eNb 4VPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744755322; x=1745360122; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ry9xEwNaBzqQYPUr2sJCAn+hzw6WkQUhzGrae9Rjk7I=; b=DZ8G/GOVEil0w2s2tA1woR7pJQfJD1jIEu/IP4ihpv8/ZkeL86T9MzrCtVqdXlQ7Tm M1zIaW8COFVB4Zh63cuardLDdLrcCqLhQ8xey0NawROYvdsET3j9Z6S7Hx4nHWUbSOSd 588NWg97JW8VTWLwqi4zshXB9brC/cg+AZyEcmeQp8IG+n/B4zqzLAQXxPgwhVFGO2Z8 /nwfM+MvPFeSoUMHK1DhZLytoS10rzkfKaDFHPTWXxG9B9yuXnzS7I3TdPD+GRrfvQak isQ2kfBddEJ41f5XtbFPekrB27Zcs00Lm9Re5UtZzEP5ITdM55WSKVEkm83pNBKy80A6 ZFvQ== X-Forwarded-Encrypted: i=1; AJvYcCUAut4WmgFfylauykrVn9jvEMkpiSGPObeV6/uq5qQ3s3LbMOIgdAzXREuF1j/eaFOkofc5zQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yw78cBMV5krfg0Ldm+3Y/wVFC0XALvnvf805q9flGKq2kPzQnor OUXou37lD6msrSkc0U0SZlagSSl/xcCPl7FPpxE+aUNb5ps0AJhNMWoWIq0PRGXqW/2zeg6DxjF gaQ== X-Google-Smtp-Source: AGHT+IG9a+i7AqRB2/IlyNo5DtSnN1pt7IPfUfiPrFvNunVgOzcitRLYND0tYsvNeLieAMV60IKunKQjhZg= X-Received: from pjci30.prod.google.com ([2002:a17:90a:3da1:b0:2fa:2891:e310]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5484:b0:2fa:137f:5c61 with SMTP id 98e67ed59e1d1-3085eeb5078mr1496593a91.12.1744755322545; Tue, 15 Apr 2025 15:15:22 -0700 (PDT) Date: Tue, 15 Apr 2025 15:15:21 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250410204149.2576104-1-ross.philipson@oracle.com> <20250410204149.2576104-10-ross.philipson@oracle.com> Message-ID: Subject: Re: [PATCH v13 09/19] x86: Secure Launch kernel early boot stub From: Sean Christopherson To: Andrew Cooper Cc: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, kexec@lists.infradead.org, linux-efi@vger.kernel.org, iommu@lists.linux.dev, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com, ardb@kernel.org, mjg59@srcf.ucam.org, James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, luto@amacapital.net, nivedita@alum.mit.edu, herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net, ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com Content-Type: text/plain; charset="us-ascii" On Tue, Apr 15, 2025, Andrew Cooper wrote: > On 11/04/2025 10:40 pm, Sean Christopherson wrote: > > On Thu, Apr 10, 2025, Ross Philipson wrote: > >> + * instruction can return for a number of reasons. Test to see if it returned > >> + * because the monitor was written to. > >> + */ > >> + monitor > >> + > >> +1: > >> + mfence > >> + mwait > >> + movl (%eax), %edx > > Why load the value into EDX? At a glance, the value is never consumed. > > > >> + testl %edx, %edx > >> + jz 1b > > This usage of MONITOR/MWAIT is flawed. The monitor needs to be re-armed in each > > loop, otherwise mwait will be a glorified nop. > > > > More importantly, the exit condition needs to be checked before monitor, > > after monitor and before mwait. Gah, yeah, I mean to say "before mwait".