Re: [PATCH V1 5/9] iommufd: IOMMU_IOAS_MAP_FILE interface

[Jason Gunthorpe <jgg@nvidia.com>]

On Sat, Sep 14, 2024 at 06:05:54AM -0700, Steve Sistare wrote:
> Define the IOMMU_IOAS_MAP_FILE ioctl interface, which allows a user to
> register memory by passing a memfd plus offset and length.
> 
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> ---
>  drivers/iommu/iommufd/ioas.c            |  5 +++++
>  drivers/iommu/iommufd/iommufd_private.h |  1 +
>  drivers/iommu/iommufd/main.c            |  2 ++
>  include/uapi/linux/iommufd.h            | 22 ++++++++++++++++++++++
>  4 files changed, 30 insertions(+)

This looks OK to me

>  /**
> + * struct iommu_ioas_map_file - ioctl(IOMMU_IOAS_MAP_FILE)
> + * @size: sizeof(struct iommu_ioas_map_file)
> + * @fd: the memfd to map
> + * @start: byte offset from start of file to map from
> + * @flags, @ios_id, @length, @iova: same as for iommu_ioas_map

But please check that the kdoc tools accept this syntax?

Jason