Re: [PATCH V2 2/9] iommufd: generalize iopt_pages address

[Nicolin Chen <nicolinc@nvidia.com>]

On Wed, Sep 25, 2024 at 07:43:22PM -0300, Jason Gunthorpe wrote:
> On Tue, Sep 24, 2024 at 01:31:37PM -0700, Nicolin Chen wrote:
> > On Tue, Sep 24, 2024 at 08:05:31AM -0700, Steve Sistare wrote:
> > > +static int iopt_map_common(struct iommufd_ctx *ictx,
> > > +			     struct io_pagetable *iopt,
> > > +                          struct iopt_pages *pages,
> > > +                          unsigned long *iova,
> > > +                          unsigned long length,
> > > +                          unsigned long start_byte,
> > > +                          int iommu_prot,
> > > +                          unsigned int flags)
> > 
> > I think we should follow the existing coding style by combining
> > lines that could fit within 80 characters each.
> 
> To make life easy the "coding style" is mostly whatever clang-format
> spits out. "git clang-format HEAD^!" for instance will adjust the
> current patch.

I see. That's useful. What's that exclamation mark at the end for?

Thanks
Nicolin