Re: [PATCH V4 9/9] iommufd: map file selftest

[Nicolin Chen <nicolinc@nvidia.com>]

On Fri, Oct 18, 2024 at 02:27:36PM -0700, Steve Sistare wrote:
> 
> Add test cases to exercise IOMMU_IOAS_MAP_FILE.
[...]
> +static int _test_ioctl_ioas_map_file(int fd, unsigned int ioas_id, int mfd,
> +                                    size_t start, size_t length, __u64 *iova,
> +                                    unsigned int flags)
> +{
> +       struct iommu_ioas_map_file cmd = {
> +               .size = sizeof(cmd),
> +               .flags = flags,
> +               .ioas_id = ioas_id,
> +               .fd = mfd,
> +               .start = start,
> +               .length = length,
> +       };
> +       int ret;
> +
> +       if (flags & IOMMU_IOAS_MAP_FIXED_IOVA)
> +               cmd.iova = *iova;
> +
> +       ret = ioctl(fd, IOMMU_IOAS_MAP_FILE, &cmd);

For a new ioctl command, There should a TEST_LENGTH in
TEST_F(iommufd, cmd_length).

Also, we might need something in iommufd_fail_nth.c too.

Thanks
Nicolin