From: Nicolin Chen <nicolinc@nvidia.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
Fenghua Yu <fenghuay@nvidia.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Zhou Wang <wangzhou1@hisilicon.com>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature()
Date: Fri, 18 Apr 2025 13:23:51 -0700 [thread overview]
Message-ID: <aAK010Tb+1AYp8F1@Asurada-Nvidia> (raw)
In-Reply-To: <20250418080130.1844424-9-baolu.lu@linux.intel.com>
On Fri, Apr 18, 2025 at 04:01:30PM +0800, Lu Baolu wrote:
> No external drivers use these interfaces anymore. Furthermore, no existing
> iommu drivers implement anything in the callbacks. Remove them to avoid
> dead code.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
With the following:
> @@ -657,9 +647,6 @@ struct iommu_ops {
> bool (*is_attach_deferred)(struct device *dev);
>
> /* Per device IOMMU features */
> - int (*dev_enable_feat)(struct device *dev, enum iommu_dev_features f);
> - int (*dev_disable_feat)(struct device *dev, enum iommu_dev_features f);
They should be dropped in the kdoc too.
next prev parent reply other threads:[~2025-04-18 20:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:01 [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 1/8] iommu/arm-smmu-v3: Put iopf enablement in the domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA Lu Baolu
2025-12-25 21:05 ` Linus Heckemann
2025-12-30 1:19 ` Jason Gunthorpe
2026-01-16 12:00 ` amdxdna breaks suspend (was: Re: [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA) Linus Heckemann
2026-01-16 15:27 ` Alex Deucher
2026-01-16 16:02 ` Jason Gunthorpe
2026-01-16 17:01 ` Lizhi Hou
2025-04-18 8:01 ` [PATCH v5 3/8] iommu/vt-d: Put iopf enablement in domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 4/8] iommufd/selftest: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 5/8] dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 6/8] uacce: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 7/8] iommufd: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature() Lu Baolu
2025-04-18 20:23 ` Nicolin Chen [this message]
2025-04-21 6:00 ` [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Zhangfei Gao
2025-04-28 11:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAK010Tb+1AYp8F1@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=fenghuay@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox