From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C4C21ABA7 for ; Tue, 29 Apr 2025 18:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949807; cv=none; b=ugpVz6UpV9Vw45jupTjzbYh2GudQUYR2JYwUb6D7AwxAXwp+hnIKctrYqg+oKFL5WOQlHsjORAFFChx9JKtvQXGZHgTfQH6UcCVwz3cL/sqAkuxwIkmVk2nDrpbujAVXa9YgFYwXMpa8topTJoxjIISMBd3kMcy4A5VqTmAGETI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949807; c=relaxed/simple; bh=/jKxrEccc/rxDV9flEdrkcq0R1bjej/EwSVckgQxFcs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RIzxRr0eM+OSCKqA8bXwlNSC5IvpFxk+t+7ehBxRVauzJenuOqR090k3KRxCq0J/Hx7N7gbfoLdWjlXzH6CzhkY99J8D6Q0WQpzNaKtpPkOneGRSsuR6/WeJFiLjm28hp4X2V1+Z598HA/TASXSVK7SnBZsxpz+EHu1myYwCqhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=p8zjoPeM; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p8zjoPeM" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2264c9d0295so199395ad.0 for ; Tue, 29 Apr 2025 11:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745949805; x=1746554605; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5gO38QVftzp7foJd8AqWRzdImXv3oAewp8XDWFfWfG4=; b=p8zjoPeM8W0Wd2yfOpohmzfFo1Q7jplmMqtJ9NwOLErg1KSja9+CV/bDObIdZI8rDn iTqofz64bFIVZoL84TMB9wgDv/wxUzXiNE0WZS5BBUZsamTwXQhht6ZOe/6dWBINSnCA iRJPaiSErzvnevd6UmgFnrfM9lgSAlvCiTHXUoK0AQ/OHhYyzJRqZ6xgEvrScAQqCIXB 4ts9Xk1AsQ48yB/yhi5F+HbNnS1R701AqOsP8eh8kjUqjf6/o27uhLIHWi5T1HKY03z7 E9AYDIl/TDiss+QOJGnWeU3j7I0Er6b9oPwRhTdkBWrnJcRihGGjra2nzommJrfiFzfV wX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745949805; x=1746554605; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5gO38QVftzp7foJd8AqWRzdImXv3oAewp8XDWFfWfG4=; b=J8aS2UieM0nOFuTo8oXWBmu2CYRtRbZEjDIwPAecZ3daZAwD3Xe+1ZOuzuC6CzCY7Q Pm48VsYLNtUiCpED+QVx/po03LtRb4cT5pSqvCLpzK3NEyVLzPl8qPQI4IheYLMg2y3y 6HSNi0HpWyN5dlVuz0FK2SgXreKl9sCXZPoQempYLOyKI6zAq/uv10ZgXpgtDxMa4qAk TqpbLQzJsaWkLneRoS68KWcDAeNyN52hezwzquMKQ2miwlUwYCoWxUIoDZL8QFi+aMDv YXc5FbG1FKCcgJNXjjMuFYoCXX+lvP5GILtIPJks5/b0KnQ9Ztmi9k1vsfGeGdZtGo5W tbTQ== X-Forwarded-Encrypted: i=1; AJvYcCUSJAZna5pMXsuNBTvbnF5YadHbucZYNWuJIwU+Lr6+4ML+C7H8/TwPExsyALuMY5R73COc1Q==@lists.linux.dev X-Gm-Message-State: AOJu0YzyT5PeUqUpbVJTobK+CF5UFPIc+RWZQ1pNdfE95xbd5qJRIW+U YCX4ivjM4tVCXJsSzKfTxj6bd83Dy5+Fss4NGoysoWbhMyKpF1Ip2AC+0KHfxA== X-Gm-Gg: ASbGnctMS8gh2TAbpp2OTMbSVZ4u6KmdVxtmHenfyGhssJOLjjQ9huJqIt4bSCEzxsH Of18sF2yZ7/j64WrgHjG3YwfBnr1bfsmPB0ONw0DxJ4ZqEdGhCILUX2xTs5X+GErSHPV8Y5Z2j1 qlB/SiH5IlYyGyPa4D/LHBNoIrfKnRY1u0j8wnfh9pAk2sgsMYQtJc4ntXbgQXRNHflGVW7xuu4 ebWzIxmOC+kbf5dsIwP0IdeFTk86X8GiQhEVCvK87CrObwaSJyWEpkdmoN+oGCRT6q2zw4crOVM tjE91vHHXhTd8+adToqyAvPYqCG5WQp5aahYIui0Surq3nHB32kx0TYr3lMIBqANQG/UOHWZ X-Google-Smtp-Source: AGHT+IHcbHv78LbKHTcjYARgVuVMIU3PlvzwcFa5Mynrm4iDVnN6pnPgBf3EmKTpPOmaL66ic8Z84Q== X-Received: by 2002:a17:902:f60a:b0:215:9ab0:402 with SMTP id d9443c01a7336-22df40757bemr145535ad.18.1745949804669; Tue, 29 Apr 2025 11:03:24 -0700 (PDT) Received: from google.com (2.210.143.34.bc.googleusercontent.com. [34.143.210.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b15faded711sm9272213a12.66.2025.04.29.11.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 11:03:24 -0700 (PDT) Date: Tue, 29 Apr 2025 18:03:13 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, bagasdotme@gmail.com, robin.murphy@arm.com, joro@8bytes.org, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, shuah@kernel.org, jsnitsel@redhat.com, nathan@kernel.org, peterz@infradead.org, yi.l.liu@intel.com, mshavit@google.com, zhangzekun11@huawei.com, iommu@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, mochs@nvidia.com, alok.a.tiwari@oracle.com, vasant.hegde@amd.com Subject: Re: [PATCH v2 08/22] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers Message-ID: References: Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 28, 2025 at 04:34:14PM -0700, Nicolin Chen wrote: > On Mon, Apr 28, 2025 at 03:12:33PM -0700, Nicolin Chen wrote: > > On Mon, Apr 28, 2025 at 08:14:19PM +0000, Pranjal Shrivastava wrote: > > > On Fri, Apr 25, 2025 at 10:58:03PM -0700, Nicolin Chen wrote: > > > > + iopt_for_each_contig_area(&iter, area, iopt, iova, last_iova) { > > > > + unsigned long last = min(last_iova, iopt_area_last_iova(area)); > > > > + unsigned long last_index = iopt_area_iova_to_index(area, last); > > > > + unsigned long index = > > > > + iopt_area_iova_to_index(area, iter.cur_iova); > > > > + > > > > + if (area->prevent_access || > > > > > > Nit: > > > Shouldn't we return -EBUSY or something if (area->prevent_access == 1) ? > > > IIUC, this just means that an unmap attempt is in progress, hence avoid > > > accessing the area. > > > > Maybe. But this is what it was. So we need a different patch to > > change that. > > Rereading the code. The prevent_access is set by an unmap(), which > means there shouldn't be any pin() and rw() as the caller should > finish unmap() first. > > In the newer use case of vCMDQ, it's similar. If VMM is unmapping > the stage-2 mapping, it shouldn't try to allocate a vCMDQ. > > -EBUSY makes some sense, but -EINVAL could still stand. > > So, I am leaving it as is, since this patch is just about moving > the functions for sharing. Ack. I don't have a strong preference too. This should be fine, we can re-visit this if needed in the future. Reviewed-by: Pranjal Shrivastava > > Nicolin Thanks!