From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045CE2264A2 for ; Mon, 16 Jun 2025 22:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750114335; cv=none; b=jLXKnMJkzkAr/2ruaF07gU+KpoEkI75DrRiz/BqR7T1CcgFsF6WITl6hiRUQCT3zvq9fIkMGzhBjiVFZCLdderrsOCHLEsfGo7KkjBwcioI0KQtYTZMgQSu94z5Ek/rfdQ+VG6Lsvuz+T6pg+UopPYxg7VCFZk3VUyeo3MCdI8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750114335; c=relaxed/simple; bh=PmDF/LX+MEY7yNxnBISXFQV1FTEkhwSQHKJS5tTjenI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ANZo/ymrS4hpurncVn8PLJnASPumTnLvyS/abaXe8lDvVKJSOWYiWaCMTMN54kH5p8ZNhn9ySi3t6+2BM7BC3TF+Ykl09O3LkCpUgb4SMjT+l5S5b633/ucEU10va1VDPoIPtt6flmd4q80PGSEkCK8z2jn37M3Uk0c06KUxtNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=TIp10kJJ; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TIp10kJJ" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-235ca5eba8cso65545ad.0 for ; Mon, 16 Jun 2025 15:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750114333; x=1750719133; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Jj6+mcpbE9V02qadLzbuN9y/flOOPMALPxxrYxqko6o=; b=TIp10kJJqgq5OzX2vnCMFtThCkpNCn81ipaXj7hWOtWy1VRQ8/oxRvVkbJLQ9kPBuZ GTUPu8/L19XU06bTisCxBIv19ebzzGRBL+lMiCvjBu4LG72JhrnBbA9unwGJsgKFIhMc c2X1F27jk9kGfVEfx7tN1mabJVi5NOOfc8r/I9leQ172qputtxTaZMgpHNddV8erBjBP Bkdx4Lw7CG7/UWf13ODB3lLa0ewCzosckLoF8fCygWK0yHKmovmwE1y0+2+1KqJ27f1z 6gt28luBaN+4zAq2pLa6NjMEBozVhYibNOZfP3aTu1plP3ufOA+2eKNWchLGtgNGMA2T n3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750114333; x=1750719133; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jj6+mcpbE9V02qadLzbuN9y/flOOPMALPxxrYxqko6o=; b=fFklkUFuJtd8lcafwFUskwsz99IbxEs0b/nQufAW+a46cT9u+jXd6Iot7LnDVKCl5p 4uiMwSc/FORJ8hf6wlvupkUEMXhFYeoah9ISsFyqOgEW+w7LeDhTKas+yPBrvKncZlTJ j2jQF928wbfACnYBm/t70LRrlb0XhxFwpuV6S6EQ4aogVFb3EbJaS871PTIDzzTYPFKb wXTWTbefU/Ik4ZfdbBkMIun6PvqAEGr14HkepIZX259Kz62XHyBQGOnPddc4zyEh1kbU vofye4vWSMnCdclQ0StKx8m0TmBMyt4b42hAojdWlyYn7gR1gAVvfXTcj3jEmx111hqT TZoQ== X-Forwarded-Encrypted: i=1; AJvYcCUXGvB1WvVzRelX5CVrbM3cYUirg6yH694K05QeEiZpnjJ2dPChfBQj8rN5xEtXCVHbJ+tAJg==@lists.linux.dev X-Gm-Message-State: AOJu0YzMYV2v52BVsDwcRJYWJPFGdAUNQfB+qPGBcn0SWiR6xqyAwyvw +/cki3xOQUyI9CxQovZ2mKK//amTOe/9X3+8ts0EjjvH2+fM9UpoJW/SXU+HJUH7jg== X-Gm-Gg: ASbGnct7nF1pqPt6r4zPnigd9Q+35ws5kfuoJ5WzF3IXu+cuUli+wJVe2xMCBl0s35A F/UC59udgzP22PWRF68f8gz2zieBXzvz4DPWKMNBdLP/6RnR6gd8+5S/K9Hh2DUYXXZTmxvDdfs fegPC1ZO6g23GDR47VehClwKeWO9FTQuKk9RQQy6t4RjXRaLiaiVtc+hTYY9RhhSYXdvt/jH9Qw MZFSeRSrjCY+bqkBpYXUzl0d32XXWdh7dnaznFIU6JKa5CeidWCZ2Frrjrj+SOVuVq7GbnIcapG qYYS8ipN437vbCYB0yS+39V0qitIIOPwZ8YLOVJZy0sSs20HpPTizKF8Za23Dl6Z7U+PqXfRfO3 P0prFv7VX/B2dTINMNpoB X-Google-Smtp-Source: AGHT+IGlPE9uP1SbbWnzOuYOIe1eDG4YyhjqWGy1/roBJfbAZkNgrizH5BthvNw3ZPe4qwD5HsBoXA== X-Received: by 2002:a17:903:b45:b0:234:b2bf:e67f with SMTP id d9443c01a7336-2366eef0269mr5964675ad.9.1750114333086; Mon, 16 Jun 2025 15:52:13 -0700 (PDT) Received: from google.com (232.98.126.34.bc.googleusercontent.com. [34.126.98.232]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b319dc80726sm3333506a12.68.2025.06.16.15.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 15:52:12 -0700 (PDT) Date: Mon, 16 Jun 2025 22:52:04 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, yi.l.liu@intel.com, peterz@infradead.org, jsnitsel@redhat.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, baolu.lu@linux.intel.com Subject: Re: [PATCH v2 13/14] iommufd: Introduce iommufd_object_alloc_ucmd helpery Message-ID: References: Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 13, 2025 at 11:35:25PM -0700, Nicolin Chen wrote: > An object allocator needs to call either iommufd_object_finalize() upon a > success or iommufd_object_abort_and_destroy() upon an error code. > > To reduce duplication, store a new_obj in the struct iommufd_ucmd and call > iommufd_object_finalize/iommufd_object_abort_and_destroy() accordingly in > the main function. > > Similar to iommufd_object_alloc() and __iommufd_object_alloc(), add a pair > of helpers: __iommufd_object_alloc_ucmd() and iommufd_object_alloc_ucmd(). > > Suggested-by: Jason Gunthorpe > Reviewed-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > Signed-off-by: Nicolin Chen > --- > drivers/iommu/iommufd/iommufd_private.h | 26 +++++++++++++++++++++++++ > drivers/iommu/iommufd/main.c | 25 ++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > > -- Acked-by: Pranjal Shrivastava > 2.43.0 >