From: Catalin Marinas <catalin.marinas@arm.com>
To: "Mikołaj Lenczewski" <miko.lenczewski@arm.com>
Cc: ryan.roberts@arm.com, yang@os.amperecomputing.com,
will@kernel.org, jean-philippe@linaro.org, robin.murphy@arm.com,
joro@8bytes.org, maz@kernel.org, oliver.upton@linux.dev,
joey.gouly@arm.com, james.morse@arm.com, broonie@kernel.org,
ardb@kernel.org, baohua@kernel.org, suzuki.poulose@arm.com,
david@redhat.com, jgg@ziepe.ca, nicolinc@nvidia.com,
jsnitsel@redhat.com, mshavit@google.com, kevin.tian@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH v7 4/4] arm64/mm: Elide tlbi in contpte_convert() under BBML2
Date: Thu, 19 Jun 2025 20:47:18 +0100 [thread overview]
Message-ID: <aFRpRnXi3tP_iHEJ@arm.com> (raw)
In-Reply-To: <aFRlDSZ2PPnHixjc@arm.com>
On Thu, Jun 19, 2025 at 08:29:24PM +0100, Catalin Marinas wrote:
> On Tue, Jun 17, 2025 at 09:51:04AM +0000, Mikołaj Lenczewski wrote:
> > + if (!system_supports_bbml2_noabort())
> > + __flush_tlb_range(&vma, start_addr, addr, PAGE_SIZE, true, 3);
> >
> > __set_ptes(mm, start_addr, start_ptep, pte, CONT_PTES);
>
> Eliding the TLBI here is all good but looking at the overall set_ptes(),
> why do we bother with unfold+fold for BBML2? Can we not just change
> them in place without going through __ptep_get_and_clear()?
Ah, it's unlikely that we'd be able to fold them back if only one pte in
the range was modified, so this optimisation would very rarely/never
trigger. So, for this patch:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2025-06-19 19:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 9:51 [PATCH v7 0/4] Initial BBML2 support for contpte_convert() Mikołaj Lenczewski
2025-06-17 9:51 ` [PATCH v7 1/4] arm64: cpufeature: Introduce MATCH_ALL_EARLY_CPUS capability type Mikołaj Lenczewski
2025-06-17 10:20 ` Suzuki K Poulose
2025-06-17 9:51 ` [PATCH v7 2/4] arm64: Add BBM Level 2 cpu feature Mikołaj Lenczewski
2025-06-17 10:35 ` Suzuki K Poulose
2025-06-18 14:07 ` Ryan Roberts
2025-06-19 8:57 ` Mikołaj Lenczewski
2025-06-19 9:20 ` Ryan Roberts
2025-06-19 11:51 ` Mikołaj Lenczewski
2025-06-19 11:05 ` Catalin Marinas
2025-06-19 11:51 ` Mikołaj Lenczewski
2025-06-19 13:46 ` Catalin Marinas
2025-06-19 14:46 ` Mikołaj Lenczewski
2025-06-17 9:51 ` [PATCH v7 3/4] iommu/arm: Add BBM Level 2 smmu feature Mikołaj Lenczewski
2025-06-19 11:36 ` Catalin Marinas
2025-06-17 9:51 ` [PATCH v7 4/4] arm64/mm: Elide tlbi in contpte_convert() under BBML2 Mikołaj Lenczewski
2025-06-19 19:29 ` Catalin Marinas
2025-06-19 19:47 ` Catalin Marinas [this message]
2025-06-20 16:10 ` Ryan Roberts
2025-06-25 13:07 ` Ryan Roberts
2025-06-25 13:37 ` Jason Gunthorpe
2025-06-25 14:16 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFRpRnXi3tP_iHEJ@arm.com \
--to=catalin.marinas@arm.com \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@ziepe.ca \
--cc=joey.gouly@arm.com \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=miko.lenczewski@arm.com \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=oliver.upton@linux.dev \
--cc=robin.murphy@arm.com \
--cc=ryan.roberts@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox