Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

[Lukas Wunner <lukas@wunner.de>]

On Wed, Jun 25, 2025 at 04:08:38PM +0200, Hans de Goede wrote:
> Lukas made me aware of this attempt to fix the KERN_CRIT msg, because
> I wrote a slightly different patch to fix this:
> 
> https://lore.kernel.org/dri-devel/20250625112411.4123-1-hansg@kernel.org/
> 
> This seems like a cleaner fix to me and something which would be good
> to have regardless since currently the driver_attach() call is doing
> too much work because the promisc table catches an unnecessary wide
> net / match matching many PCI devices which cannot be AGP capable
> at all.

So how do you know that all of these unsupported devices have
PCI_CLASS_BRIDGE_HOST?  The only thing we know is that an AGP
Capability must be present.

In particular, AGP 3.0 sec 2.5 explicitly allows PCI-to-PCI bridges
in addition to Host-to-PCI bridges.

Thanks,

Lukas