Re: [RFC PATCH v3 5/8] pm: runtime: Introduce pm_runtime_get_if_not_suspended()

[Pranjal Shrivastava <praan@google.com>]

On Tue, Jul 08, 2025 at 03:00:07PM -0700, Nicolin Chen wrote:
> On Mon, Jun 16, 2025 at 08:31:46PM +0000, Pranjal Shrivastava wrote:
> > +int pm_runtime_get_if_not_suspended(struct device *dev)
> > +{
> > +	unsigned long flags;
> > +	int retval;
> > +
> > +	spin_lock_irqsave(&dev->power.lock, flags);
> > +	if (dev->power.disable_depth > 0) {
> > +		retval = -EINVAL;
> > +		goto out;
> > +	}
> > +
> > +	if (dev->power.runtime_status == RPM_SUSPENDED) {
> > +		retval = 0;
> > +		goto out;
> > +	}
> > +
> > +	/* Cancel the auto-suspend timer */
> > +	pm_runtime_cancel_pending(dev);
> > +	atomic_inc(&dev->power.usage_count);
> > +	__update_runtime_status(dev, RPM_ACTIVE);
> > +	retval = 1;
> [...]
> > +	spin_unlock_irqrestore(&dev->power.lock, flags);
> > +
> > +	return retval;
> > +out:
> > +	spin_unlock_irqrestore(&dev->power.lock, flags);
> > +	return retval;
> > +}
>  
> One pair is enough.

Ack. Will fix this.