From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ben Copeland <ben.copeland@linaro.org>,
linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org,
regressions@lists.linux.dev, linux-nvme@lists.infradead.org,
Dan Carpenter <dan.carpenter@linaro.org>,
axboe@kernel.dk, sagi@grimberg.me, iommu@lists.linux.dev
Subject: Re: next-20250627: IOMMU DMA warning during NVMe I/O completion after 06cae0e3f61c
Date: Mon, 30 Jun 2025 18:54:19 -0600 [thread overview]
Message-ID: <aGMxu6Yn514Xy55w@kbusch-mbp> (raw)
In-Reply-To: <aGLyswGYD6Zai_sI@kbusch-mbp>
On Mon, Jun 30, 2025 at 02:25:23PM -0600, Keith Busch wrote:
> On Mon, Jun 30, 2025 at 03:33:43PM +0200, Christoph Hellwig wrote:
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -701,7 +701,7 @@ static void nvme_free_prps(struct request *req)
> prp_list = iod->descriptors[desc];
> do {
> dma_unmap_page(dma_dev, dma_addr, dma_len, dir);
> - if (i == NVME_CTRL_PAGE_SIZE >> 3) {
> + if (i == NVME_CTRL_PAGE_SIZE >> 3 && length > NVME_CTRL_PAGE_SIZE) {
> prp_list = iod->descriptors[++desc];
> i = 0;
> }
> --
>
> But even that, the PRP setup doesn't match the teardown. We're calling
> dma_map_page() on each PRP even if consecutive PRP's [...]
Err, I meant to say "dma_unmap_page()".
next prev parent reply other threads:[~2025-07-01 0:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL0q8a6pOBZbWYdwKzC1U-PuH4rgf2miv0jcF=fWVZt_dUZHmw@mail.gmail.com>
2025-06-30 13:33 ` next-20250627: IOMMU DMA warning during NVMe I/O completion after 06cae0e3f61c Christoph Hellwig
2025-06-30 19:51 ` Ben Copeland
2025-07-01 19:43 ` Keith Busch
2025-06-30 20:25 ` Keith Busch
2025-07-01 0:54 ` Keith Busch [this message]
2025-07-01 13:05 ` Ben Copeland
2025-07-01 14:20 ` Keith Busch
2025-07-01 13:29 ` Christoph Hellwig
2025-07-01 15:58 ` Leon Romanovsky
2025-07-01 21:00 ` Keith Busch
2025-07-03 9:30 ` Christoph Hellwig
2025-07-03 14:29 ` Keith Busch
2025-07-03 15:13 ` Ben Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGMxu6Yn514Xy55w@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=ben.copeland@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lkft-triage@lists.linaro.org \
--cc=regressions@lists.linux.dev \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox