From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3F5346E5A for ; Thu, 8 Jan 2026 14:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881321; cv=none; b=cx5dn/9yP4B1nXoDrFrLUs04TB0ZvyijTqTZ4bbXJa65If8gZH+Jp8mKd8CJy3Q9FWiiN7EM4DcDs6wnyPxLRuDUiemVP0dvLt8wHgSZg+d/lfBZOLfcIvIxTsR/2k+pk+fxD+wS+ItEJFJRFA4tIg+z8w/WauA7gMikqY/QJAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881321; c=relaxed/simple; bh=Tv7zh9Hk92kdNn+K2fPlpE9fTBNWYFWSvOonEurgOJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=NoV95+2GV/RWKXwuJivpZH0RkjpF3oduNd9EVeP85nMNDYwpWN/SWeuTdeY14YIz89UQE66sEnZTHV5T7i4qui8QKKPHRnfMVCj3FXl3qDRvohQx8Fghk+rm1AIgcbOvY1eAFwP8zLDyshY4Rj/3SuodKXGiqJBqWsOu8t9MNGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JMv34wXl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JMv34wXl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767881319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qb0opi0EkMyYcYBrprImauJ5+csaYa0bSdovEgtQBZs=; b=JMv34wXl46/FnDYIPBeZ51sXipwgk6pezAGY39bqTlzPzqGLwhRvYA/iMaoSBPaRx9mLmE WPsMmMtnHKxBdSGceUrsdOCiOOR846ppp2hyrm4iDkWlsJ7yXyPyGNQfRhlC14giF8oheA VeRS8FI//u7LGUMkUMyNIwT1lF2XALc= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-uxD6oLH9P1GORGlqi9cy2A-1; Thu, 08 Jan 2026 09:08:38 -0500 X-MC-Unique: uxD6oLH9P1GORGlqi9cy2A-1 X-Mimecast-MFC-AGG-ID: uxD6oLH9P1GORGlqi9cy2A_1767881317 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b831e10ba03so499396666b.1 for ; Thu, 08 Jan 2026 06:08:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767881317; x=1768486117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qb0opi0EkMyYcYBrprImauJ5+csaYa0bSdovEgtQBZs=; b=krax/10cXhGVP/pQJmg1NUB1yHui99SvewN4SGkQnl8YV1yff6KquKjqFX5iB6S3cE JgfvfwCv+HxDSFMLmNYfcSugEMLu/+bvrYWV05U6FtTedEMvZOHNmWu6tTxKVIOy/Cp0 u/yAdoRHTeuxDreiYn/aC2cRjuWDzj9E2G7WKBM6M/xUv+qzDN1IOgjj5xWviu7sJtCT 9zuTEw67VcC0zX6XS6rJgrGhoTg9ZqlL13gE9/2MNOEzt3P7zuC6wb2QK1AX9ZgXgjpy 9T99VmLKWeANmVEzSs0ntPZO0iHRCmKPIl3s4PsJc3eEWfQHZypAfgaStomAyDuRpJRi 1ibw== X-Forwarded-Encrypted: i=1; AJvYcCXsWuRAwMapaTbobhlTezo6SkAsILLPcTy5FWSFGxKqoI5AJ3blPnDEDdgRClkgx+lRRGgYnQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yz+fshUDcHFjBcfKf+tYAF+WlUgFa4vQLJkAIjw9VX1Xo66HYgt Smv+J37wN7Z2UOkwBNVsZqZyPETWuccLQKPxBmib1rNMzecS/n2UrSxfOptQ3F9BKAUTCXsRrr7 CSoM5YYYk3Voi3vVC+C07n+x8pc3tmm9bc5prXgDTneH5n+qMhqYgk7TZ X-Gm-Gg: AY/fxX47/t5VrKll1o4WRcY8eDUXyst/bzJt0Op6PPvZvXiRDH98EWDy7TBkpZPH8g3 xmU/t327b4Wky2BcTKkupkVECEi9IJW1wZnO/v0oYqvo/8fZB5Y1fUL9vD+TAMj1BZ11liCpRL2 y/LlgWn0GT/V1ixB3pSH6AwL9fpCqRt5UsgEY7Oqn3Ov2LpTi4+1fD4wa7qutFynz2s42H3Vi/l eYjC4tYSFH8ibSlYscS0DzMHVa02DAry67IlkwRIBWrggM8jnex/KleAybrpVCJOBk6e0Zp/iNq U/cvjtEW8ZwXopb+l+lQYK6aVPuAiI6J9xKHkHV8awtFo1hSQsYDAGSoUo2jCvvAjpz2G7+cyKC 8GDXzkdKjMHE8Q7wd X-Received: by 2002:a17:907:7b89:b0:b6d:6c1a:31ae with SMTP id a640c23a62f3a-b8444fd453amr620664966b.49.1767881317032; Thu, 08 Jan 2026 06:08:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7HOHiWGYK4xorotJbNX0jMidX1ixXQJJ1VdDBrRK+mMgTkrWVhdGn0FKO7KNa9bc9HZtucg== X-Received: by 2002:a17:907:7b89:b0:b6d:6c1a:31ae with SMTP id a640c23a62f3a-b8444fd453amr620660466b.49.1767881316491; Thu, 08 Jan 2026 06:08:36 -0800 (PST) Received: from sgarzare-redhat ([193.207.223.215]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a2cb447sm843387866b.29.2026.01.08.06.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:08:35 -0800 (PST) Date: Thu, 8 Jan 2026 15:08:31 +0100 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 08/15] vsock/virtio: use virtqueue_add_inbuf_cache_clean for events Message-ID: References: <4b5bf63a7ebb782d87f643466b3669df567c9fe1.1767601130.git.mst@redhat.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <4b5bf63a7ebb782d87f643466b3669df567c9fe1.1767601130.git.mst@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 66fPuud_7sMZEbsDQNPVYZ-aTCRLqaq-v3GBX4LSzps_1767881317 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Jan 05, 2026 at 03:23:21AM -0500, Michael S. Tsirkin wrote: >The event_list array contains 8 small (4-byte) events that share >cachelines with each other. When CONFIG_DMA_API_DEBUG is enabled, >this can trigger warnings about overlapping DMA mappings within >the same cacheline. > >The previous patch isolated event_list in its own cache lines >so the warnings are spurious. > >Use virtqueue_add_inbuf_cache_clean() to indicate that the CPU does not >write into these fields, suppressing the warnings. > >Reported-by: Cong Wang >Signed-off-by: Michael S. Tsirkin >--- > net/vmw_vsock/virtio_transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Stefano Garzarella > >diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c >index bb94baadfd8b..ef983c36cb66 100644 >--- a/net/vmw_vsock/virtio_transport.c >+++ b/net/vmw_vsock/virtio_transport.c >@@ -392,7 +392,7 @@ static int virtio_vsock_event_fill_one(struct virtio_vsock *vsock, > > sg_init_one(&sg, event, sizeof(*event)); > >- return virtqueue_add_inbuf(vq, &sg, 1, event, GFP_KERNEL); >+ return virtqueue_add_inbuf_cache_clean(vq, &sg, 1, event, GFP_KERNEL); > } > > /* event_lock must be held */ >-- >MST >