From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A60D79C8; Wed, 26 Jul 2023 06:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690351877; x=1721887877; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=WDQtGHcWzopAoO6Fwuln0OAiUSdM4jJjH8FxFV/d+w0=; b=L0oM9r/23+H3sVWogYiqutCoV0Qtk12jbeCxMQ1utzZz7FNYek0diqlr o+QtLunvFzxxYppdLDNDpQDcQ2ejAMsw4HrVU1rnvZC6smnEnxrKgqOH5 JA+ZjSMMXLK6Xu2GhyrORfn71R/u18MAq+zcGIXVQM2HpeaHKsFGJPu++ 2gJJUdudnoXoTDb0t7adxhrFu7k41RI5UOqRsYRLV8iP+BU/LjfKnVCz8 ksX7cRZnPjiMWICEupRg2T4jX3YrTeNtG27QLhis6RYuIwkM3p1hFLPTo pqglFT+hp0cZWheg4iyDMXtlKvN+J2ROPbZKc9T8JFyPtCwJlT6SQkFUx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="434186764" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="434186764" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 23:11:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="816538258" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="816538258" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.208.129]) ([10.254.208.129]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 23:11:06 -0700 Message-ID: Date: Wed, 26 Jul 2023 14:11:04 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v5 01/25] iommu: Add iommu_ops->identity_domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <1-v5-d0a204c678c7+3d16a-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <1-v5-d0a204c678c7+3d16a-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/7/25 1:21, Jason Gunthorpe wrote: > This allows a driver to set a global static to an IDENTITY domain and > the core code will automatically use it whenever an IDENTITY domain > is requested. > > By making it always available it means the IDENTITY can be used in error > handling paths to force the iommu driver into a known state. Devices > implementing global static identity domains should avoid failing their > attach_dev ops. > > Convert rockchip to use the new mechanism. > > Tested-by: Steven Price > Tested-by: Marek Szyprowski > Tested-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/iommu.c | 3 +++ > drivers/iommu/rockchip-iommu.c | 9 +-------- > include/linux/iommu.h | 3 +++ > 3 files changed, 7 insertions(+), 8 deletions(-) I will later convert the VT-d driver to use iommu_ops->identity_domain. Reviewed-by: Lu Baolu