public inbox for iommu@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: <iommu@lists.linux.dev>, <linuxppc-dev@lists.ozlabs.org>,
	<joerg.roedel@amd.com>, <jgg@nvidia.com>,
	<baolu.lu@linux.intel.com>, <kevin.tian@intel.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>, <sbhat@linux.ibm.com>
Subject: Re: [bug report]: iommu WARNING is observed on powerpc system during pci enumeration at boot up
Date: Mon, 9 Mar 2026 11:48:44 -0700	[thread overview]
Message-ID: <aa8WDIhPyPU45VKB@Asurada-Nvidia> (raw)
In-Reply-To: <d5c834ff-4c95-44dd-8bef-57242d63aeee@linux.ibm.com>

On Mon, Mar 09, 2026 at 11:27:42PM +0530, Nilay Shroff wrote:
> Looking at the warning it seems that this is a regression caused due to
> commit a75b2be249d6 ("iommu: Add iommu_driver_get_domain_for_dev() helper").
> 
> Any help from the iommu expert would be appreciated. Though I am not expert,
> it seems the following patch help fix this warning (I encourage the iommu
> developers to confirm and/or take this forward) :
> 
> diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
> index 0ce71310b7d9..d122e8447831 100644
> --- a/arch/powerpc/kernel/iommu.c
> +++ b/arch/powerpc/kernel/iommu.c
> @@ -1159,7 +1159,7 @@ spapr_tce_platform_iommu_attach_dev(struct iommu_domain *platform_domain,
>                                     struct device *dev,
>                                     struct iommu_domain *old)
>  {
> -       struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
> +       struct iommu_domain *domain = iommu_driver_get_domain_for_dev(dev);
>         struct iommu_table_group *table_group;
>         struct iommu_group *grp;
> 
> 
> Please let me know if any further information is needed.

Yea, that should be the fix.

Please submit a "PATCH rc" with:

Fixes: a75b2be249d6 ("iommu: Add iommu_driver_get_domain_for_dev() helper")
Cc: stable@vger.kernel.org

Thanks!
Nicolin

  reply	other threads:[~2026-03-09 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 17:57 [bug report]: iommu WARNING is observed on powerpc system during pci enumeration at boot up Nilay Shroff
2026-03-09 18:48 ` Nicolin Chen [this message]
2026-03-12  5:13   ` Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa8WDIhPyPU45VKB@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joerg.roedel@amd.com \
    --cc=kevin.tian@intel.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=nilay@linux.ibm.com \
    --cc=sbhat@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox